Title: [243016] trunk/Source/WebKit
Revision
243016
Author
[email protected]
Date
2019-03-15 15:18:21 -0700 (Fri, 15 Mar 2019)

Log Message

_WKDownload should conform to NSCopying protocol
https://bugs.webkit.org/show_bug.cgi?id=195718

Reviewed by Tim Horton.

This will allow us to use it as keys in NSMutableDictionaries, which Safari already kind of does.

* UIProcess/API/Cocoa/_WKDownload.h:
* UIProcess/API/Cocoa/_WKDownload.mm:
(-[_WKDownload copyWithZone:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (243015 => 243016)


--- trunk/Source/WebKit/ChangeLog	2019-03-15 22:06:42 UTC (rev 243015)
+++ trunk/Source/WebKit/ChangeLog	2019-03-15 22:18:21 UTC (rev 243016)
@@ -1,3 +1,16 @@
+2019-03-15  Alex Christensen  <[email protected]>
+
+        _WKDownload should conform to NSCopying protocol
+        https://bugs.webkit.org/show_bug.cgi?id=195718
+
+        Reviewed by Tim Horton.
+
+        This will allow us to use it as keys in NSMutableDictionaries, which Safari already kind of does.
+
+        * UIProcess/API/Cocoa/_WKDownload.h:
+        * UIProcess/API/Cocoa/_WKDownload.mm:
+        (-[_WKDownload copyWithZone:]):
+
 2019-03-15  Dean Jackson  <[email protected]>
 
         Provide an option for an always-on fast click mode in iOS

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h (243015 => 243016)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h	2019-03-15 22:06:42 UTC (rev 243015)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.h	2019-03-15 22:18:21 UTC (rev 243016)
@@ -30,7 +30,7 @@
 @class WKWebView;
 
 WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0))
-@interface _WKDownload : NSObject
+@interface _WKDownload : NSObject <NSCopying>
 
 - (void)cancel;
 

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm (243015 => 243016)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm	2019-03-15 22:06:42 UTC (rev 243015)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm	2019-03-15 22:18:21 UTC (rev 243016)
@@ -83,6 +83,11 @@
     return WebKit::wrapper(_download->resumeData());
 }
 
+- (id)copyWithZone:(NSZone *)zone
+{
+    return [self retain];
+}
+
 #pragma mark WKObject protocol implementation
 
 - (API::Object&)_apiObject
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to