Title: [243055] trunk
- Revision
- 243055
- Author
- [email protected]
- Date
- 2019-03-17 19:16:59 -0700 (Sun, 17 Mar 2019)
Log Message
[Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
https://bugs.webkit.org/show_bug.cgi?id=195741
Reviewed by Ross Kirsling.
Source/WebKitLegacy/win:
* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
LayoutTests:
* platform/wincairo/TestExpectations: Unskipped http/tests/ssl/ping-with-unsafe-redirect.html.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (243054 => 243055)
--- trunk/LayoutTests/ChangeLog 2019-03-18 02:08:14 UTC (rev 243054)
+++ trunk/LayoutTests/ChangeLog 2019-03-18 02:16:59 UTC (rev 243055)
@@ -1,3 +1,12 @@
+2019-03-17 Fujii Hironori <[email protected]>
+
+ [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
+ https://bugs.webkit.org/show_bug.cgi?id=195741
+
+ Reviewed by Ross Kirsling.
+
+ * platform/wincairo/TestExpectations: Unskipped http/tests/ssl/ping-with-unsafe-redirect.html.
+
2019-03-16 Jer Noble <[email protected]>
Add a new MediaCapabilitiesExtensionsEnabled setting
Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (243054 => 243055)
--- trunk/LayoutTests/platform/wincairo/TestExpectations 2019-03-18 02:08:14 UTC (rev 243054)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations 2019-03-18 02:16:59 UTC (rev 243055)
@@ -954,7 +954,6 @@
http/tests/ssl/iframe-upgrade.https.html [ Skip ]
http/tests/ssl/mixedContent/insecure-websocket.html [ Failure ]
-webkit.org/b/195741 http/tests/ssl/ping-with-unsafe-redirect.html [ Skip ]
http/tests/ssl/upgrade-origin-usage.html [ Failure ]
http/tests/ssl/media-stream [ Skip ]
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (243054 => 243055)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2019-03-18 02:08:14 UTC (rev 243054)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2019-03-18 02:16:59 UTC (rev 243055)
@@ -1,3 +1,13 @@
+2019-03-17 Fujii Hironori <[email protected]>
+
+ [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
+ https://bugs.webkit.org/show_bug.cgi?id=195741
+
+ Reviewed by Ross Kirsling.
+
+ * WebCoreSupport/WebFrameNetworkingContext.cpp:
+ (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
+
2019-03-13 Ryan Haddad <[email protected]>
Unreviewed attempt to fix the Windows build after r242920.
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameNetworkingContext.cpp (243054 => 243055)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameNetworkingContext.cpp 2019-03-18 02:08:14 UTC (rev 243054)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameNetworkingContext.cpp 2019-03-18 02:16:59 UTC (rev 243055)
@@ -109,7 +109,7 @@
{
ASSERT(isMainThread());
- if (frame() && frame()->page()->usesEphemeralSession())
+ if (frame() && frame()->page() && frame()->page()->usesEphemeralSession())
return NetworkStorageSessionMap::storageSession(PAL::SessionID::legacyPrivateSessionID());
return &NetworkStorageSessionMap::defaultStorageSession();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
