Title: [243106] trunk/Source/WebCore
- Revision
- 243106
- Author
- [email protected]
- Date
- 2019-03-18 14:57:54 -0700 (Mon, 18 Mar 2019)
Log Message
Remove unused webkitEditableContentChanged event
https://bugs.webkit.org/show_bug.cgi?id=195909
Reviewed by Wenson Hsieh.
Removed webkitEditableContentChanged event which is no longer used after r206944.
Note that only WebKit's C++ code can fire events in TextControlInnerElements
since the element is an implementation detail of input and textarea elements.
* dom/EventNames.h:
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::defaultEventHandler):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243105 => 243106)
--- trunk/Source/WebCore/ChangeLog 2019-03-18 21:30:58 UTC (rev 243105)
+++ trunk/Source/WebCore/ChangeLog 2019-03-18 21:57:54 UTC (rev 243106)
@@ -1,3 +1,19 @@
+2019-03-18 Ryosuke Niwa <[email protected]>
+
+ Remove unused webkitEditableContentChanged event
+ https://bugs.webkit.org/show_bug.cgi?id=195909
+
+ Reviewed by Wenson Hsieh.
+
+ Removed webkitEditableContentChanged event which is no longer used after r206944.
+
+ Note that only WebKit's C++ code can fire events in TextControlInnerElements
+ since the element is an implementation detail of input and textarea elements.
+
+ * dom/EventNames.h:
+ * html/shadow/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerTextElement::defaultEventHandler):
+
2019-03-18 Myles C. Maxfield <[email protected]>
[WHLSL] Hook up the compiler to our WebGPU implementation
Modified: trunk/Source/WebCore/dom/EventNames.h (243105 => 243106)
--- trunk/Source/WebCore/dom/EventNames.h 2019-03-18 21:30:58 UTC (rev 243105)
+++ trunk/Source/WebCore/dom/EventNames.h 2019-03-18 21:57:54 UTC (rev 243106)
@@ -302,7 +302,6 @@
macro(webkitAnimationIteration) \
macro(webkitAnimationStart) \
macro(webkitBeforeTextInserted) \
- macro(webkitEditableContentChanged) \
macro(webkitTransitionEnd) \
macro(webkitbeginfullscreen) \
macro(webkitcurrentplaybacktargetiswirelesschanged) \
Modified: trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp (243105 => 243106)
--- trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2019-03-18 21:30:58 UTC (rev 243105)
+++ trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2019-03-18 21:57:54 UTC (rev 243106)
@@ -148,15 +148,14 @@
// FIXME: In the future, we should add a way to have default event listeners.
// Then we would add one to the text field's inner div, and we wouldn't need this subclass.
// Or possibly we could just use a normal event listener.
- if (event.isBeforeTextInsertedEvent() || event.type() == eventNames().webkitEditableContentChangedEvent) {
- RefPtr<Element> shadowAncestor = shadowHost();
+ if (event.isBeforeTextInsertedEvent()) {
// A TextControlInnerTextElement can have no host if its been detached,
// but kept alive by an EditCommand. In this case, an undo/redo can
// cause events to be sent to the TextControlInnerTextElement. To
// prevent an infinite loop, we must check for this case before sending
// the event up the chain.
- if (shadowAncestor)
- shadowAncestor->defaultEventHandler(event);
+ if (auto host = makeRefPtr(shadowHost()))
+ host->defaultEventHandler(event);
}
if (!event.defaultHandled())
HTMLDivElement::defaultEventHandler(event);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
