Title: [243115] trunk/Source/WTF
Revision
243115
Author
[email protected]
Date
2019-03-18 16:51:42 -0700 (Mon, 18 Mar 2019)

Log Message

[WTF] Remove redundant std::move in StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=195798

Patch by Xan Lopez <[email protected]> on 2019-03-18
Reviewed by Darin Adler.

Remove redundant calls to WTFMove in return values for this
method. C++ will already do an implicit move here since we are
returning a local value where copy/move elision is not applicable.

* wtf/text/StringConcatenate.h:
(WTF::tryMakeStringFromAdapters):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (243114 => 243115)


--- trunk/Source/WTF/ChangeLog	2019-03-18 23:33:10 UTC (rev 243114)
+++ trunk/Source/WTF/ChangeLog	2019-03-18 23:51:42 UTC (rev 243115)
@@ -1,3 +1,17 @@
+2019-03-18  Xan Lopez  <[email protected]>
+
+        [WTF] Remove redundant std::move in StringConcatenate
+        https://bugs.webkit.org/show_bug.cgi?id=195798
+
+        Reviewed by Darin Adler.
+
+        Remove redundant calls to WTFMove in return values for this
+        method. C++ will already do an implicit move here since we are
+        returning a local value where copy/move elision is not applicable.
+
+        * wtf/text/StringConcatenate.h:
+        (WTF::tryMakeStringFromAdapters):
+
 2019-03-16  Darin Adler  <[email protected]>
 
         Improve normalization code, including moving from unorm.h to unorm2.h

Modified: trunk/Source/WTF/wtf/text/StringConcatenate.h (243114 => 243115)


--- trunk/Source/WTF/wtf/text/StringConcatenate.h	2019-03-18 23:33:10 UTC (rev 243114)
+++ trunk/Source/WTF/wtf/text/StringConcatenate.h	2019-03-18 23:51:42 UTC (rev 243115)
@@ -278,7 +278,7 @@
 
         makeStringAccumulator(buffer, adapter, adapters...);
 
-        return WTFMove(resultImpl);
+        return resultImpl;
     }
 
     UChar* buffer;
@@ -288,7 +288,7 @@
 
     makeStringAccumulator(buffer, adapter, adapters...);
 
-    return WTFMove(resultImpl);
+    return resultImpl;
 }
 
 template<typename... StringTypes>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to