Title: [243123] trunk/Websites/perf.webkit.org
- Revision
- 243123
- Author
- [email protected]
- Date
- 2019-03-18 18:55:13 -0700 (Mon, 18 Mar 2019)
Log Message
Fix a bug from r226303 that latest build time is not correctly calculated.
https://bugs.webkit.org/show_bug.cgi?id=195912
Reviewed by Ryosuke Niwa.
Time series is ordered by revision time which does not grantee the build time is
monotonically increasing.
* public/v3/pages/test-freshness-page.js: Use the latest build time instead of the build time of
last point on the chart.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (243122 => 243123)
--- trunk/Websites/perf.webkit.org/ChangeLog 2019-03-19 01:32:04 UTC (rev 243122)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2019-03-19 01:55:13 UTC (rev 243123)
@@ -1,3 +1,16 @@
+2019-03-18 Dewei Zhu <[email protected]>
+
+ Fix a bug from r226303 that latest build time is not correctly calculated.
+ https://bugs.webkit.org/show_bug.cgi?id=195912
+
+ Reviewed by Ryosuke Niwa.
+
+ Time series is ordered by revision time which does not grantee the build time is
+ monotonically increasing.
+
+ * public/v3/pages/test-freshness-page.js: Use the latest build time instead of the build time of
+ last point on the chart.
+
2019-03-13 Dewei Zhu <[email protected]>
Test freshness page should improve the ability to correlating issues from same builder.
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js (243122 => 243123)
--- trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-03-19 01:32:04 UTC (rev 243122)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/test-freshness-page.js 2019-03-19 01:55:13 UTC (rev 243123)
@@ -88,17 +88,26 @@
measurementSet.fetchBetween(startTime, this._measurementSetFetchTime).then(() => {
const currentTimeSeries = measurementSet.fetchedTimeSeries('current', false, false);
- let timeForLastDataPoint = startTime;
+ let timeForLatestBuild = startTime;
let lastBuildLink = null;
let builder = null;
const lastPoint = currentTimeSeries.lastPoint();
if (lastPoint) {
- timeForLastDataPoint = lastPoint.build().buildTime();
- lastBuildLink = lastPoint.build().url();
- builder = lastPoint.build().builder();
+ timeForLatestBuild = lastPoint.build().buildTime().getTime();
+ const view = currentTimeSeries.viewBetweenPoints(currentTimeSeries.firstPoint(), lastPoint);
+ for (const point of view) {
+ const build = point.build();
+ if (!build)
+ continue;
+ if (build.buildTime().getTime() >= timeForLatestBuild) {
+ timeForLatestBuild = build.buildTime().getTime();
+ lastBuildLink = build.url();
+ builder = build.builder();
+ }
+ }
}
- lastDataPointByMetric.set(metric, {time: timeForLastDataPoint, hasCurrentDataPoint: !!currentTimeSeries.lastPoint(),
+ lastDataPointByMetric.set(metric, {time: timeForLatestBuild, hasCurrentDataPoint: !!lastPoint,
lastBuildLink, builder});
this.enqueueToRender();
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
