Title: [243156] trunk/Source/WebKit
- Revision
- 243156
- Author
- [email protected]
- Date
- 2019-03-19 11:44:18 -0700 (Tue, 19 Mar 2019)
Log Message
REGRESSION (r243094): internal media test fairplay-hls-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=195954
<rdar://problem/49005981>
Reviewed by Geoffrey Garen.
TestController::resetStateToConsistentValues() tries to send a "reset" message to its
injected bundle. Part of the "reset" message sets the external hosts that we're allowed
to load. If there is no WebProcess yet when WKPagePostMessageToInjectedBundle() is called,
then this message does not get sent and the allowed hosts do not get set, causing this
test failure.
To address the issue, make sure we launch the initial process if necessary when
WebPageProxy::postMessageToInjectedBundle() is called, in order to maintain backward
compatibility.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::postMessageToInjectedBundle):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243155 => 243156)
--- trunk/Source/WebKit/ChangeLog 2019-03-19 18:41:37 UTC (rev 243155)
+++ trunk/Source/WebKit/ChangeLog 2019-03-19 18:44:18 UTC (rev 243156)
@@ -1,5 +1,26 @@
2019-03-19 Chris Dumez <[email protected]>
+ REGRESSION (r243094): internal media test fairplay-hls-error.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=195954
+ <rdar://problem/49005981>
+
+ Reviewed by Geoffrey Garen.
+
+ TestController::resetStateToConsistentValues() tries to send a "reset" message to its
+ injected bundle. Part of the "reset" message sets the external hosts that we're allowed
+ to load. If there is no WebProcess yet when WKPagePostMessageToInjectedBundle() is called,
+ then this message does not get sent and the allowed hosts do not get set, causing this
+ test failure.
+
+ To address the issue, make sure we launch the initial process if necessary when
+ WebPageProxy::postMessageToInjectedBundle() is called, in order to maintain backward
+ compatibility.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::postMessageToInjectedBundle):
+
+2019-03-19 Chris Dumez <[email protected]>
+
Unreviewed, rolling out r243142.
Caused assertion hits in WK2 Debug
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (243155 => 243156)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-03-19 18:41:37 UTC (rev 243155)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-03-19 18:44:18 UTC (rev 243156)
@@ -5815,6 +5815,9 @@
void WebPageProxy::postMessageToInjectedBundle(const String& messageName, API::Object* messageBody)
{
+ // For backward-compatibility, make sure we launch the initial process if the client asks to post a message to its injected bundle because doing a load.
+ launchInitialProcessIfNecessary();
+
process().send(Messages::WebPage::PostInjectedBundleMessage(messageName, UserData(process().transformObjectsToHandles(messageBody).get())), m_pageID);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
