Title: [243203] trunk/Source/WebKit
- Revision
- 243203
- Author
- [email protected]
- Date
- 2019-03-20 09:10:17 -0700 (Wed, 20 Mar 2019)
Log Message
Unreviewed, drop invalid assertions landed in r243163.
Those assertions were causing some API tests to crash.
Also include some post-review suggestions from Darin.
* Shared/CallbackID.h:
(WebKit::CallbackID::operator=):
* Shared/OptionalCallbackID.h:
(WebKit::OptionalCallbackID::operator=):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243202 => 243203)
--- trunk/Source/WebKit/ChangeLog 2019-03-20 15:59:40 UTC (rev 243202)
+++ trunk/Source/WebKit/ChangeLog 2019-03-20 16:10:17 UTC (rev 243203)
@@ -1,5 +1,17 @@
2019-03-20 Chris Dumez <[email protected]>
+ Unreviewed, drop invalid assertions landed in r243163.
+
+ Those assertions were causing some API tests to crash.
+ Also include some post-review suggestions from Darin.
+
+ * Shared/CallbackID.h:
+ (WebKit::CallbackID::operator=):
+ * Shared/OptionalCallbackID.h:
+ (WebKit::OptionalCallbackID::operator=):
+
+2019-03-20 Chris Dumez <[email protected]>
+
Unreviewed, fix assertion failures in API tests after r243159.
* UIProcess/VisitedLinkStore.cpp:
Modified: trunk/Source/WebKit/Shared/CallbackID.h (243202 => 243203)
--- trunk/Source/WebKit/Shared/CallbackID.h 2019-03-20 15:59:40 UTC (rev 243202)
+++ trunk/Source/WebKit/Shared/CallbackID.h 2019-03-20 16:10:17 UTC (rev 243203)
@@ -49,10 +49,7 @@
ALWAYS_INLINE CallbackID& operator=(const CallbackID& otherID)
{
- if (this == &otherID)
- return *this;
m_id = otherID.m_id;
- ASSERT(HashTraits<uint64_t>::emptyValue() != m_id && !HashTraits<uint64_t>::isDeletedValue(m_id));
return *this;
}
Modified: trunk/Source/WebKit/Shared/OptionalCallbackID.h (243202 => 243203)
--- trunk/Source/WebKit/Shared/OptionalCallbackID.h 2019-03-20 15:59:40 UTC (rev 243202)
+++ trunk/Source/WebKit/Shared/OptionalCallbackID.h 2019-03-20 16:10:17 UTC (rev 243203)
@@ -48,10 +48,7 @@
ALWAYS_INLINE OptionalCallbackID& operator=(const OptionalCallbackID& otherID)
{
- if (this == &otherID)
- return *this;
m_id = otherID.m_id;
- ASSERT(!HashTraits<uint64_t>::isDeletedValue(m_id));
return *this;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
