Title: [243220] trunk/Source/WebInspectorUI
- Revision
- 243220
- Author
- [email protected]
- Date
- 2019-03-20 11:58:04 -0700 (Wed, 20 Mar 2019)
Log Message
Web Inspector: Console: add a setting for controlling auto-expansion of Trace messages
https://bugs.webkit.org/show_bug.cgi?id=195690
Reviewed by Timothy Hatcher.
* UserInterface/Views/ConsoleMessageView.js:
(WI.ConsoleMessageView.prototype._appendStackTrace):
* UserInterface/Base/Setting.js:
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (243219 => 243220)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-20 18:53:47 UTC (rev 243219)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-20 18:58:04 UTC (rev 243220)
@@ -1,5 +1,21 @@
2019-03-20 Devin Rousso <[email protected]>
+ Web Inspector: Console: add a setting for controlling auto-expansion of Trace messages
+ https://bugs.webkit.org/show_bug.cgi?id=195690
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ConsoleMessageView.js:
+ (WI.ConsoleMessageView.prototype._appendStackTrace):
+
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
+
+ * Localizations/en.lproj/localizedStrings.js:
+
+2019-03-20 Devin Rousso <[email protected]>
+
Web Inspector: DOM: selecting a node in a different frame should automatically switch the console prompt's execution context
https://bugs.webkit.org/show_bug.cgi?id=195805
<rdar://problem/48930866>
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (243219 => 243220)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-03-20 18:53:47 UTC (rev 243219)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-03-20 18:58:04 UTC (rev 243220)
@@ -145,6 +145,7 @@
localizedStrings["Auto"] = "Auto";
localizedStrings["Auto - %s"] = "Auto - %s";
localizedStrings["Auto Increment"] = "Auto Increment";
+localizedStrings["Auto-expand Traces"] = "Auto-expand Traces";
localizedStrings["Automatically continue after evaluating"] = "Automatically continue after evaluating";
localizedStrings["Available Style Sheets"] = "Available Style Sheets";
localizedStrings["Average CPU: %s"] = "Average CPU: %s";
@@ -263,6 +264,7 @@
localizedStrings["Console Profile Recorded"] = "Console Profile Recorded";
localizedStrings["Console cleared at %s"] = "Console cleared at %s";
localizedStrings["Console opened at %s"] = "Console opened at %s";
+localizedStrings["Console:"] = "Console:";
localizedStrings["Containing"] = "Containing";
localizedStrings["Content"] = "Content";
localizedStrings["Content Security Policy violation of directive: %s"] = "Content Security Policy violation of directive: %s";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (243219 => 243220)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-03-20 18:53:47 UTC (rev 243219)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2019-03-20 18:58:04 UTC (rev 243220)
@@ -127,6 +127,7 @@
WI.settings = {
canvasRecordingAutoCaptureEnabled: new WI.Setting("canvas-recording-auto-capture-enabled", false),
canvasRecordingAutoCaptureFrameCount: new WI.Setting("canvas-recording-auto-capture-frame-count", 1),
+ consoleAutoExpandTrace: new WI.Setting("console-auto-expand-trace", true),
cssChangesPerNode: new WI.Setting("css-changes-per-node", false),
clearLogOnNavigate: new WI.Setting("clear-log-on-navigate", true),
clearNetworkOnNavigate: new WI.Setting("clear-network-on-navigate", true),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (243219 => 243220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2019-03-20 18:53:47 UTC (rev 243219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2019-03-20 18:58:04 UTC (rev 243220)
@@ -416,8 +416,7 @@
this._makeExpandable();
- // Auto-expand for console.trace.
- if (this._message.type === WI.ConsoleMessage.MessageType.Trace)
+ if (this._message.type === WI.ConsoleMessage.MessageType.Trace && WI.settings.consoleAutoExpandTrace.value)
this.expand();
this._stackTraceElement = this._element.appendChild(document.createElement("div"));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (243219 => 243220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-03-20 18:53:47 UTC (rev 243219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2019-03-20 18:58:04 UTC (rev 243220)
@@ -208,6 +208,7 @@
generalSettingsView.addSetting(WI.UIString("Debugger:"), WI.settings.showScopeChainOnPause, WI.UIString("Show Scope Chain on pause"));
generalSettingsView.addSetting(WI.UIString("Source maps:"), WI.settings.sourceMapsEnabled, WI.UIString("Enable source maps"));
+ generalSettingsView.addSetting(WI.UIString("Console:"), WI.settings.consoleAutoExpandTrace, WI.UIString("Auto-expand Traces"));
generalSettingsView.addSeparator();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
