Title: [243231] trunk/Source/WebKit
- Revision
- 243231
- Author
- [email protected]
- Date
- 2019-03-20 13:18:49 -0700 (Wed, 20 Mar 2019)
Log Message
[GTK] REGRESSION(r243094): crash when launching minibrowser
https://bugs.webkit.org/show_bug.cgi?id=195951
Patch by Carlos Garcia Campos <[email protected]> on 2019-03-20
Reviewed by Joseph Pecoraro.
Always return the inspector from WebPageProxy::inspector() when the page hasn't been closed. The inspector is
created in WebPageProxy constructor and it's safe to use even before a process has been launched, because
m_inspectedPage is null-checked everywhere.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::inspector const):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243230 => 243231)
--- trunk/Source/WebKit/ChangeLog 2019-03-20 19:58:06 UTC (rev 243230)
+++ trunk/Source/WebKit/ChangeLog 2019-03-20 20:18:49 UTC (rev 243231)
@@ -1,3 +1,17 @@
+2019-03-20 Carlos Garcia Campos <[email protected]>
+
+ [GTK] REGRESSION(r243094): crash when launching minibrowser
+ https://bugs.webkit.org/show_bug.cgi?id=195951
+
+ Reviewed by Joseph Pecoraro.
+
+ Always return the inspector from WebPageProxy::inspector() when the page hasn't been closed. The inspector is
+ created in WebPageProxy constructor and it's safe to use even before a process has been launched, because
+ m_inspectedPage is null-checked everywhere.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::inspector const):
+
2019-03-20 Keith Rollin <[email protected]>
Update checks that determine if WebKit is system WebKit
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (243230 => 243231)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-03-20 19:58:06 UTC (rev 243230)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-03-20 20:18:49 UTC (rev 243231)
@@ -5528,7 +5528,7 @@
WebInspectorProxy* WebPageProxy::inspector() const
{
- if (isClosed() || !hasRunningProcess())
+ if (isClosed())
return nullptr;
return m_inspector.get();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
