Title: [243236] trunk/Source/_javascript_Core
- Revision
- 243236
- Author
- [email protected]
- Date
- 2019-03-20 13:37:01 -0700 (Wed, 20 Mar 2019)
Log Message
DFGNodeAllocator.h is dead code
https://bugs.webkit.org/show_bug.cgi?id=196019
Reviewed by Yusuke Suzuki.
As explained by Yusuke on IRC, the comment on DFG::Node saying that it cannot have a destructor is obsolete since https://trac.webkit.org/changeset/216815/webkit.
This patch removes both the comment and DFGNodeAllocator.h that that patch forgot to remove.
* dfg/DFGNode.h:
(JSC::DFG::Node::dumpChildren):
* dfg/DFGNodeAllocator.h: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243235 => 243236)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-20 20:35:25 UTC (rev 243235)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-20 20:37:01 UTC (rev 243236)
@@ -1,5 +1,19 @@
2019-03-20 Robin Morisset <[email protected]>
+ DFGNodeAllocator.h is dead code
+ https://bugs.webkit.org/show_bug.cgi?id=196019
+
+ Reviewed by Yusuke Suzuki.
+
+ As explained by Yusuke on IRC, the comment on DFG::Node saying that it cannot have a destructor is obsolete since https://trac.webkit.org/changeset/216815/webkit.
+ This patch removes both the comment and DFGNodeAllocator.h that that patch forgot to remove.
+
+ * dfg/DFGNode.h:
+ (JSC::DFG::Node::dumpChildren):
+ * dfg/DFGNodeAllocator.h: Removed.
+
+2019-03-20 Robin Morisset <[email protected]>
+
Compress CodeOrigin into a single word in the common case
https://bugs.webkit.org/show_bug.cgi?id=195928
Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (243235 => 243236)
--- trunk/Source/_javascript_Core/dfg/DFGNode.h 2019-03-20 20:35:25 UTC (rev 243235)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h 2019-03-20 20:37:01 UTC (rev 243236)
@@ -2887,8 +2887,6 @@
return;
out.printf(", @%u", child3()->index());
}
-
- // NB. This class must have a trivial destructor.
NodeOrigin origin;
Deleted: trunk/Source/_javascript_Core/dfg/DFGNodeAllocator.h (243235 => 243236)
--- trunk/Source/_javascript_Core/dfg/DFGNodeAllocator.h 2019-03-20 20:35:25 UTC (rev 243235)
+++ trunk/Source/_javascript_Core/dfg/DFGNodeAllocator.h 2019-03-20 20:37:01 UTC (rev 243236)
@@ -1,44 +0,0 @@
-/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#pragma once
-
-#if ENABLE(DFG_JIT)
-
-#include "DFGNode.h"
-
-namespace JSC { namespace DFG {
-
-typedef Allocator<Node> NodeAllocator;
-
-} } // namespace JSC::DFG
-
-inline void* operator new (size_t size, JSC::DFG::NodeAllocator& allocator)
-{
- ASSERT_UNUSED(size, size == sizeof(JSC::DFG::Node));
- return allocator.allocate();
-}
-
-#endif // ENABLE(DFG_JIT)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
