Title: [243248] trunk/Tools
- Revision
- 243248
- Author
- [email protected]
- Date
- 2019-03-20 15:48:04 -0700 (Wed, 20 Mar 2019)
Log Message
REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
https://bugs.webkit.org/show_bug.cgi?id=196031
<rdar://problem/49078172>
Reviewed by Tim Horton.
The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
<select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
same code path used when the Done button is pressed to dismiss the <select> picker.
* TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (243247 => 243248)
--- trunk/Tools/ChangeLog 2019-03-20 22:15:03 UTC (rev 243247)
+++ trunk/Tools/ChangeLog 2019-03-20 22:48:04 UTC (rev 243248)
@@ -1,3 +1,18 @@
+2019-03-20 Daniel Bates <[email protected]>
+
+ REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
+ https://bugs.webkit.org/show_bug.cgi?id=196031
+ <rdar://problem/49078172>
+
+ Reviewed by Tim Horton.
+
+ The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
+ <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
+ same code path used when the Done button is pressed to dismiss the <select> picker.
+
+ * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
+ (TestWebKitAPI::TEST):
+
2019-03-20 Chris Dumez <[email protected]>
Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/FocusPreservationTests.mm (243247 => 243248)
--- trunk/Tools/TestWebKitAPI/Tests/ios/FocusPreservationTests.mm 2019-03-20 22:15:03 UTC (rev 243247)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/FocusPreservationTests.mm 2019-03-20 22:48:04 UTC (rev 243248)
@@ -96,7 +96,7 @@
EXPECT_NOT_NULL(webView.textInputContentView.inputView);
[webView selectFormAccessoryPickerRow:1];
- EXPECT_TRUE([webView resignFirstResponder]);
+ [webView dismissFormAccessoryView];
EXPECT_FALSE([webView stringByEvaluatingJavaScript:@"document.activeElement == document.querySelector('select')"].boolValue);
EXPECT_EQ(1, [webView stringByEvaluatingJavaScript:@"document.querySelector('select').selectedIndex"].intValue);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
