Title: [243268] trunk/Source/_javascript_Core
- Revision
- 243268
- Author
- [email protected]
- Date
- 2019-03-20 17:40:04 -0700 (Wed, 20 Mar 2019)
Log Message
GetCallee does not report the correct type in AI
https://bugs.webkit.org/show_bug.cgi?id=195981
Reviewed by Yusuke Suzuki.
I found this as part of my work in:
https://bugs.webkit.org/show_bug.cgi?id=195924
I'm not sure how to write a test for it.
GetCallee was always reporting that the result is SpecFunction. However,
for eval, it may result in just a JSCallee object, which is not a JSFunction.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243267 => 243268)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-21 00:36:06 UTC (rev 243267)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-21 00:40:04 UTC (rev 243268)
@@ -1,3 +1,21 @@
+2019-03-20 Saam Barati <[email protected]>
+
+ GetCallee does not report the correct type in AI
+ https://bugs.webkit.org/show_bug.cgi?id=195981
+
+ Reviewed by Yusuke Suzuki.
+
+ I found this as part of my work in:
+ https://bugs.webkit.org/show_bug.cgi?id=195924
+
+ I'm not sure how to write a test for it.
+
+ GetCallee was always reporting that the result is SpecFunction. However,
+ for eval, it may result in just a JSCallee object, which is not a JSFunction.
+
+ * dfg/DFGAbstractInterpreterInlines.h:
+ (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+
2019-03-20 Mark Lam <[email protected]>
Open source arm64e code.
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (243267 => 243268)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2019-03-21 00:36:06 UTC (rev 243267)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2019-03-21 00:40:04 UTC (rev 243268)
@@ -2730,7 +2730,7 @@
break;
}
}
- setTypeForNode(node, SpecFunction);
+ setTypeForNode(node, SpecFunction | SpecObjectOther);
break;
case GetArgumentCountIncludingThis:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
