Title: [243295] trunk/Source/_javascript_Core
- Revision
- 243295
- Author
- [email protected]
- Date
- 2019-03-21 09:45:25 -0700 (Thu, 21 Mar 2019)
Log Message
CachedUnlinkedSourceCodeShape::m_provider should be a CachedRefPtr
https://bugs.webkit.org/show_bug.cgi?id=196079
Reviewed by Saam Barati.
It was mistakenly cached as CachedPtr, which was leaking the decoded SourceProvider.
* runtime/CachedTypes.cpp:
(JSC::CachedUnlinkedSourceCodeShape::encode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243294 => 243295)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-21 16:36:20 UTC (rev 243294)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-21 16:45:25 UTC (rev 243295)
@@ -1,3 +1,15 @@
+2019-03-21 Tadeu Zagallo <[email protected]>
+
+ CachedUnlinkedSourceCodeShape::m_provider should be a CachedRefPtr
+ https://bugs.webkit.org/show_bug.cgi?id=196079
+
+ Reviewed by Saam Barati.
+
+ It was mistakenly cached as CachedPtr, which was leaking the decoded SourceProvider.
+
+ * runtime/CachedTypes.cpp:
+ (JSC::CachedUnlinkedSourceCodeShape::encode):
+
2019-03-21 Mark Lam <[email protected]>
Placate exception check validation in operationArrayIndexOfString().
Modified: trunk/Source/_javascript_Core/runtime/CachedTypes.cpp (243294 => 243295)
--- trunk/Source/_javascript_Core/runtime/CachedTypes.cpp 2019-03-21 16:36:20 UTC (rev 243294)
+++ trunk/Source/_javascript_Core/runtime/CachedTypes.cpp 2019-03-21 16:45:25 UTC (rev 243295)
@@ -1475,7 +1475,7 @@
public:
void encode(Encoder& encoder, const UnlinkedSourceCode& sourceCode)
{
- m_provider.encode(encoder, sourceCode.m_provider.get());
+ m_provider.encode(encoder, sourceCode.m_provider);
m_startOffset = sourceCode.startOffset();
m_endOffset = sourceCode.endOffset();
}
@@ -1488,7 +1488,7 @@
}
private:
- CachedPtr<CachedSourceProvider> m_provider;
+ CachedRefPtr<CachedSourceProvider> m_provider;
int m_startOffset;
int m_endOffset;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
