Title: [243321] trunk/Tools
- Revision
- 243321
- Author
- [email protected]
- Date
- 2019-03-21 13:39:59 -0700 (Thu, 21 Mar 2019)
Log Message
REGRESSSION (r243297): webkitpy tests broken
https://bugs.webkit.org/show_bug.cgi?id=196108
Reviewed by Aakash Jain.
r243297 updated contributors.json, which broke a few unit tests.
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
* Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (243320 => 243321)
--- trunk/Tools/ChangeLog 2019-03-21 20:31:19 UTC (rev 243320)
+++ trunk/Tools/ChangeLog 2019-03-21 20:39:59 UTC (rev 243321)
@@ -1,3 +1,16 @@
+2019-03-21 Jonathan Bedard <[email protected]>
+
+ REGRESSSION (r243297): webkitpy tests broken
+ https://bugs.webkit.org/show_bug.cgi?id=196108
+
+ Reviewed by Aakash Jain.
+
+ r243297 updated contributors.json, which broke a few unit tests.
+
+ * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
+ (IRCCommandTest.test_whois):
+ * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
+
2019-03-21 Chris Dumez <[email protected]>
WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py (243320 => 243321)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py 2019-03-21 20:31:19 UTC (rev 243320)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py 2019-03-21 20:39:59 UTC (rev 243321)
@@ -58,7 +58,7 @@
whois.execute("tom", [u'Osztrogon\u00e1c'], None, None))
self.assertEqual('tom: "Vicki Murley" <[email protected]> hasn\'t told me their nick. Boo hoo :-(',
whois.execute("tom", ["[email protected]"], None, None))
- self.assertEqual('tom: I\'m not sure who you mean? "Gavin Barraclough" <[email protected]> (:gbarra) (r) or "Gavin Peters" <[email protected]> (:gavinp) (c) could be \'Gavin\'.',
+ self.assertEqual('tom: I\'m not sure who you mean? "Gavin Barraclough" <[email protected]> (:gbarra) (r) or "Gavin Peters" <[email protected]> (:gavinp) could be \'Gavin\'.',
whois.execute("tom", ["Gavin"], None, None))
self.assertEqual('tom: More than 5 contributors match \'david\', could you be more specific?',
whois.execute("tom", ["david"], None, None))
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations_unittest.py (243320 => 243321)
--- trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations_unittest.py 2019-03-21 20:31:19 UTC (rev 243320)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations_unittest.py 2019-03-21 20:39:59 UTC (rev 243321)
@@ -95,7 +95,7 @@
"""
def test_basic(self):
- expected_stdout = "REVIEWER: Xianzhu Wang ([email protected]) has 88 reviewed patches\n"
+ expected_stdout = "COMMITTER: Xianzhu Wang ([email protected]) has 88 reviewed patches\n"
options = self._make_options()
suggest_nominations = SuggestNominations()
suggest_nominations._init_options(options=options)
@@ -103,7 +103,7 @@
self.assert_execute_outputs(suggest_nominations, [], expected_stdout=expected_stdout, options=options)
def test_with_verbose(self):
- expected_stdout = "REVIEWER: Xianzhu Wang ([email protected]) has 88 reviewed patches\nCONTRIBUTOR: Xianzhu Wang ([email protected]) has 88 reviewed patches\n"
+ expected_stdout = "COMMITTER: Xianzhu Wang ([email protected]) has 88 reviewed patches\nCONTRIBUTOR: Xianzhu Wang ([email protected]) has 88 reviewed patches\n"
options = self._make_options(verbose=True)
suggest_nominations = SuggestNominations()
suggest_nominations._init_options(options=options)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
