Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (243322 => 243323)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-21 20:42:40 UTC (rev 243322)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-21 20:47:34 UTC (rev 243323)
@@ -1,3 +1,25 @@
+2019-03-21 Michael Catanzaro <[email protected]>
+
+ Unreviewed, more clang 3.8 build fixes
+ https://bugs.webkit.org/show_bug.cgi?id=195947
+ <rdar://problem/49069219>
+
+ In the spirit of making our code worse to please old compilers....
+
+ * bindings/ScriptValue.cpp:
+ (Inspector::jsToInspectorValue):
+ * bytecode/GetterSetterAccessCase.cpp:
+ (JSC::GetterSetterAccessCase::create):
+ (JSC::GetterSetterAccessCase::clone const):
+ * bytecode/InstanceOfAccessCase.cpp:
+ (JSC::InstanceOfAccessCase::clone const):
+ * bytecode/IntrinsicGetterAccessCase.cpp:
+ (JSC::IntrinsicGetterAccessCase::clone const):
+ * bytecode/ModuleNamespaceAccessCase.cpp:
+ (JSC::ModuleNamespaceAccessCase::clone const):
+ * bytecode/ProxyableAccessCase.cpp:
+ (JSC::ProxyableAccessCase::clone const):
+
2019-03-21 Yusuke Suzuki <[email protected]>
[JSC] Do not create JIT related data under non-JIT mode
Modified: trunk/Source/_javascript_Core/bindings/ScriptValue.cpp (243322 => 243323)
--- trunk/Source/_javascript_Core/bindings/ScriptValue.cpp 2019-03-21 20:42:40 UTC (rev 243322)
+++ trunk/Source/_javascript_Core/bindings/ScriptValue.cpp 2019-03-21 20:47:34 UTC (rev 243323)
@@ -74,7 +74,7 @@
return nullptr;
inspectorArray->pushValue(WTFMove(elementValue));
}
- return inspectorArray;
+ return RefPtr<JSON::Value> { WTFMove(inspectorArray) };
}
VM& vm = scriptState.vm();
auto inspectorObject = JSON::Object::create();
@@ -87,7 +87,7 @@
return nullptr;
inspectorObject->setValue(name.string(), WTFMove(inspectorValue));
}
- return inspectorObject;
+ return RefPtr<JSON::Value> { WTFMove(inspectorObject) };
}
ASSERT_NOT_REACHED();
Modified: trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp (243322 => 243323)
--- trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp 2019-03-21 20:42:40 UTC (rev 243322)
+++ trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp 2019-03-21 20:47:34 UTC (rev 243323)
@@ -66,7 +66,7 @@
std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, viaProxy, additionalSet, customSlotBase, WTFMove(prototypeAccessChain)));
result->m_domAttribute = domAttribute;
result->m_customAccessor = customGetter ? FunctionPtr<OperationPtrTag>(customGetter) : nullptr;
- return result;
+ return std::unique_ptr<AccessCase> { WTFMove(result) };
}
std::unique_ptr<AccessCase> GetterSetterAccessCase::create(VM& vm, JSCell* owner, AccessType type, Structure* structure, PropertyOffset offset,
@@ -76,7 +76,7 @@
ASSERT(type == Setter || type == CustomValueSetter || type == CustomAccessorSetter);
std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, false, nullptr, customSlotBase, WTFMove(prototypeAccessChain)));
result->m_customAccessor = customSetter ? FunctionPtr<OperationPtrTag>(customSetter) : nullptr;
- return result;
+ return std::unique_ptr<AccessCase> { WTFMove(result) };
}
@@ -97,7 +97,7 @@
{
std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(*this));
result->resetState();
- return result;
+ return std::unique_ptr<AccessCase> { WTFMove(result) };
}
bool GetterSetterAccessCase::hasAlternateBase() const
Modified: trunk/Source/_javascript_Core/bytecode/InstanceOfAccessCase.cpp (243322 => 243323)
--- trunk/Source/_javascript_Core/bytecode/InstanceOfAccessCase.cpp 2019-03-21 20:42:40 UTC (rev 243322)
+++ trunk/Source/_javascript_Core/bytecode/InstanceOfAccessCase.cpp 2019-03-21 20:47:34 UTC (rev 243323)
@@ -47,7 +47,7 @@
{
std::unique_ptr<InstanceOfAccessCase> result(new InstanceOfAccessCase(*this));
result->resetState();
- return result;
+ return std::unique_ptr<AccessCase> { WTFMove(result) };
}
InstanceOfAccessCase::~InstanceOfAccessCase()
Modified: trunk/Source/_javascript_Core/bytecode/IntrinsicGetterAccessCase.cpp (243322 => 243323)
--- trunk/Source/_javascript_Core/bytecode/IntrinsicGetterAccessCase.cpp 2019-03-21 20:42:40 UTC (rev 243322)
+++ trunk/Source/_javascript_Core/bytecode/IntrinsicGetterAccessCase.cpp 2019-03-21 20:47:34 UTC (rev 243323)
@@ -51,7 +51,7 @@
{
std::unique_ptr<IntrinsicGetterAccessCase> result(new IntrinsicGetterAccessCase(*this));
result->resetState();
- return result;
+ return std::unique_ptr<AccessCase> { WTFMove(result) };
}
} // namespace JSC
Modified: trunk/Source/_javascript_Core/bytecode/ModuleNamespaceAccessCase.cpp (243322 => 243323)
--- trunk/Source/_javascript_Core/bytecode/ModuleNamespaceAccessCase.cpp 2019-03-21 20:42:40 UTC (rev 243322)
+++ trunk/Source/_javascript_Core/bytecode/ModuleNamespaceAccessCase.cpp 2019-03-21 20:47:34 UTC (rev 243323)
@@ -58,7 +58,7 @@
{
std::unique_ptr<ModuleNamespaceAccessCase> result(new ModuleNamespaceAccessCase(*this));
result->resetState();
- return result;
+ return std::unique_ptr<AccessCase> { WTFMove(result) };
}
void ModuleNamespaceAccessCase::emit(AccessGenerationState& state, MacroAssembler::JumpList& fallThrough)
Modified: trunk/Source/_javascript_Core/bytecode/ProxyableAccessCase.cpp (243322 => 243323)
--- trunk/Source/_javascript_Core/bytecode/ProxyableAccessCase.cpp 2019-03-21 20:42:40 UTC (rev 243322)
+++ trunk/Source/_javascript_Core/bytecode/ProxyableAccessCase.cpp 2019-03-21 20:47:34 UTC (rev 243323)
@@ -52,7 +52,7 @@
{
std::unique_ptr<ProxyableAccessCase> result(new ProxyableAccessCase(*this));
result->resetState();
- return result;
+ return std::unique_ptr<AccessCase> { WTFMove(result) };
}
void ProxyableAccessCase::dumpImpl(PrintStream& out, CommaPrinter& comma) const
