Title: [243378] trunk/Source/WebKit
- Revision
- 243378
- Author
- [email protected]
- Date
- 2019-03-22 09:03:31 -0700 (Fri, 22 Mar 2019)
Log Message
REGRESSION(r243094): Automation: browser crash in WebAutomationSession::exitFullscreenWindowForPage()
https://bugs.webkit.org/show_bug.cgi?id=196140
Patch by Carlos Garcia Campos <[email protected]> on 2019-03-22
Reviewed by Chris Dumez.
Since r243094, the WebPageProxy fullscreen manager is not created in the constructor, but once the page has a
process launched.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::exitFullscreenWindowForPage): Null check WebPageProxy::fullScreenManager() before
using it.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243377 => 243378)
--- trunk/Source/WebKit/ChangeLog 2019-03-22 15:54:54 UTC (rev 243377)
+++ trunk/Source/WebKit/ChangeLog 2019-03-22 16:03:31 UTC (rev 243378)
@@ -1,3 +1,17 @@
+2019-03-22 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r243094): Automation: browser crash in WebAutomationSession::exitFullscreenWindowForPage()
+ https://bugs.webkit.org/show_bug.cgi?id=196140
+
+ Reviewed by Chris Dumez.
+
+ Since r243094, the WebPageProxy fullscreen manager is not created in the constructor, but once the page has a
+ process launched.
+
+ * UIProcess/Automation/WebAutomationSession.cpp:
+ (WebKit::WebAutomationSession::exitFullscreenWindowForPage): Null check WebPageProxy::fullScreenManager() before
+ using it.
+
2019-03-22 Timothy Hatcher <[email protected]>
Change macosx() to macos() in WK_API... and JSC_API... macros.
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (243377 => 243378)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2019-03-22 15:54:54 UTC (rev 243377)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2019-03-22 16:03:31 UTC (rev 243378)
@@ -598,7 +598,7 @@
{
#if ENABLE(FULLSCREEN_API)
ASSERT(!m_windowStateTransitionCallback);
- if (!page.fullScreenManager()->isFullScreen()) {
+ if (!page.fullScreenManager() || !page.fullScreenManager()->isFullScreen()) {
completionHandler();
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
