Title: [243479] trunk/Source/WebKit
- Revision
- 243479
- Author
- [email protected]
- Date
- 2019-03-25 18:36:52 -0700 (Mon, 25 Mar 2019)
Log Message
Enable IPC sending and receiving non-default-constructible types
https://bugs.webkit.org/show_bug.cgi?id=196132
<rdar://problem/49229221>
Unreviewed build fix for WinCairo port.
error C2440: '=': cannot convert from 'int' to 'HANDLE'
* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::Handle): std::exchange HANDLE with nullptr, not 0.
(WebKit::SharedMemory::Handle::operator=): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243478 => 243479)
--- trunk/Source/WebKit/ChangeLog 2019-03-26 01:26:11 UTC (rev 243478)
+++ trunk/Source/WebKit/ChangeLog 2019-03-26 01:36:52 UTC (rev 243479)
@@ -1,5 +1,19 @@
2019-03-25 Fujii Hironori <[email protected]>
+ Enable IPC sending and receiving non-default-constructible types
+ https://bugs.webkit.org/show_bug.cgi?id=196132
+ <rdar://problem/49229221>
+
+ Unreviewed build fix for WinCairo port.
+
+ error C2440: '=': cannot convert from 'int' to 'HANDLE'
+
+ * Platform/win/SharedMemoryWin.cpp:
+ (WebKit::SharedMemory::Handle::Handle): std::exchange HANDLE with nullptr, not 0.
+ (WebKit::SharedMemory::Handle::operator=): Ditto.
+
+2019-03-25 Fujii Hironori <[email protected]>
+
[Coordinated Graphics][WinCairo] ASSERTION FAILED: state.id == m_nicosia.state.id
https://bugs.webkit.org/show_bug.cgi?id=196190
Modified: trunk/Source/WebKit/Platform/win/SharedMemoryWin.cpp (243478 => 243479)
--- trunk/Source/WebKit/Platform/win/SharedMemoryWin.cpp 2019-03-26 01:26:11 UTC (rev 243478)
+++ trunk/Source/WebKit/Platform/win/SharedMemoryWin.cpp 2019-03-26 01:36:52 UTC (rev 243479)
@@ -41,13 +41,13 @@
SharedMemory::Handle::Handle(Handle&& other)
{
- m_handle = std::exchange(other.m_handle, 0);
+ m_handle = std::exchange(other.m_handle, nullptr);
m_size = std::exchange(other.m_size, 0);
}
auto SharedMemory::Handle::operator=(Handle&& other) -> Handle&
{
- m_handle = std::exchange(other.m_handle, 0);
+ m_handle = std::exchange(other.m_handle, nullptr);
m_size = std::exchange(other.m_size, 0);
return *this;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
