Title: [243484] trunk
- Revision
- 243484
- Author
- [email protected]
- Date
- 2019-03-25 21:45:13 -0700 (Mon, 25 Mar 2019)
Log Message
Remove some now-unnecessary dynamic class lookup
https://bugs.webkit.org/show_bug.cgi?id=196237
Reviewed by Simon Fraser.
Source/WebKit:
* Shared/DocumentEditingContext.mm:
(WebKit::DocumentEditingContext::toPlatformContext):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
(makeRequest):
(TEST):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243483 => 243484)
--- trunk/Source/WebKit/ChangeLog 2019-03-26 03:34:43 UTC (rev 243483)
+++ trunk/Source/WebKit/ChangeLog 2019-03-26 04:45:13 UTC (rev 243484)
@@ -1,5 +1,15 @@
2019-03-25 Tim Horton <[email protected]>
+ Remove some now-unnecessary dynamic class lookup
+ https://bugs.webkit.org/show_bug.cgi?id=196237
+
+ Reviewed by Simon Fraser.
+
+ * Shared/DocumentEditingContext.mm:
+ (WebKit::DocumentEditingContext::toPlatformContext):
+
+2019-03-25 Tim Horton <[email protected]>
+
Get rid of ENABLE(ANIMATED_KEYBOARD_SCROLLING)
https://bugs.webkit.org/show_bug.cgi?id=196224
Modified: trunk/Source/WebKit/Shared/DocumentEditingContext.mm (243483 => 243484)
--- trunk/Source/WebKit/Shared/DocumentEditingContext.mm 2019-03-26 03:34:43 UTC (rev 243483)
+++ trunk/Source/WebKit/Shared/DocumentEditingContext.mm 2019-03-26 04:45:13 UTC (rev 243484)
@@ -42,7 +42,7 @@
UIWKDocumentContext *DocumentEditingContext::toPlatformContext(OptionSet<DocumentEditingContextRequest::Options> options)
{
#if HAVE(UI_WK_DOCUMENT_CONTEXT)
- RetainPtr<UIWKDocumentContext> platformContext = adoptNS([[NSClassFromString(@"UIWKDocumentContext") alloc] init]);
+ auto platformContext = adoptNS([[UIWKDocumentContext alloc] init]);
if (options.contains(DocumentEditingContextRequest::Options::AttributedText)) {
[platformContext setContextBefore:contextBefore.string.get()];
Modified: trunk/Tools/ChangeLog (243483 => 243484)
--- trunk/Tools/ChangeLog 2019-03-26 03:34:43 UTC (rev 243483)
+++ trunk/Tools/ChangeLog 2019-03-26 04:45:13 UTC (rev 243484)
@@ -1,3 +1,14 @@
+2019-03-25 Tim Horton <[email protected]>
+
+ Remove some now-unnecessary dynamic class lookup
+ https://bugs.webkit.org/show_bug.cgi?id=196237
+
+ Reviewed by Simon Fraser.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
+ (makeRequest):
+ (TEST):
+
2019-03-25 Fujii Hironori <[email protected]>
Unreviewed, rolling out r243450.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm (243483 => 243484)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm 2019-03-26 03:34:43 UTC (rev 243483)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm 2019-03-26 04:45:13 UTC (rev 243484)
@@ -59,7 +59,7 @@
static UIWKDocumentRequest *makeRequest(UIWKDocumentRequestFlags flags, UITextGranularity granularity, NSInteger granularityCount, CGRect documentRect = CGRectZero, id <NSCopying> inputElementIdentifier = nil)
{
- RetainPtr<UIWKDocumentRequest> request = adoptNS([[NSClassFromString(@"UIWKDocumentRequest") alloc] init]);
+ auto request = adoptNS([[UIWKDocumentRequest alloc] init]);
[request setFlags:flags];
[request setSurroundingGranularity:granularity];
[request setGranularityCount:granularityCount];
@@ -117,9 +117,6 @@
TEST(WebKit, DocumentEditingContext)
{
- if (!NSClassFromString(@"UIWKDocumentRequest"))
- return;
-
RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
UIWKDocumentContext *context;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
