Title: [243524] trunk/Source
- Revision
- 243524
- Author
- [email protected]
- Date
- 2019-03-26 16:29:13 -0700 (Tue, 26 Mar 2019)
Log Message
Inhibit CFNetwork logging in private sessions
https://bugs.webkit.org/show_bug.cgi?id=196268
<rdar://problem/48210793>
Reviewed by Alex Christensen.
Before performing any logging, the NetworkProcess checks to see if
it's performing an operation associated with a private (ephemeral)
browsing session. If so, it skips the logging. However, networking
layers below the NetworkProcess don't know about private browsing, so
they would still perform their own logging. CFNetwork now has a flag
that lets us control that, so set it to False if private browsing.
Source/WebKit:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):
Source/WTF:
* wtf/Platform.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (243523 => 243524)
--- trunk/Source/WTF/ChangeLog 2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WTF/ChangeLog 2019-03-26 23:29:13 UTC (rev 243524)
@@ -1,3 +1,20 @@
+2019-03-26 Keith Rollin <[email protected]>
+
+ Inhibit CFNetwork logging in private sessions
+ https://bugs.webkit.org/show_bug.cgi?id=196268
+ <rdar://problem/48210793>
+
+ Reviewed by Alex Christensen.
+
+ Before performing any logging, the NetworkProcess checks to see if
+ it's performing an operation associated with a private (ephemeral)
+ browsing session. If so, it skips the logging. However, networking
+ layers below the NetworkProcess don't know about private browsing, so
+ they would still perform their own logging. CFNetwork now has a flag
+ that lets us control that, so set it to False if private browsing.
+
+ * wtf/Platform.h:
+
2019-03-25 Alex Christensen <[email protected]>
Expected shouldn't assume its contained types are copyable
Modified: trunk/Source/WTF/wtf/Platform.h (243523 => 243524)
--- trunk/Source/WTF/wtf/Platform.h 2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WTF/wtf/Platform.h 2019-03-26 23:29:13 UTC (rev 243524)
@@ -1525,3 +1525,7 @@
#if PLATFORM(IOSMAC)
#define ENABLE_PLATFORM_DRIVEN_TEXT_CHECKING 1
#endif
+
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
+#define HAVE_ALLOWS_SENSITIVE_LOGGING 1
+#endif
Modified: trunk/Source/WebKit/ChangeLog (243523 => 243524)
--- trunk/Source/WebKit/ChangeLog 2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WebKit/ChangeLog 2019-03-26 23:29:13 UTC (rev 243524)
@@ -1,3 +1,21 @@
+2019-03-26 Keith Rollin <[email protected]>
+
+ Inhibit CFNetwork logging in private sessions
+ https://bugs.webkit.org/show_bug.cgi?id=196268
+ <rdar://problem/48210793>
+
+ Reviewed by Alex Christensen.
+
+ Before performing any logging, the NetworkProcess checks to see if
+ it's performing an operation associated with a private (ephemeral)
+ browsing session. If so, it skips the logging. However, networking
+ layers below the NetworkProcess don't know about private browsing, so
+ they would still perform their own logging. CFNetwork now has a flag
+ that lets us control that, so set it to False if private browsing.
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (WebKit::configurationForSessionID):
+
2019-03-26 Chris Dumez <[email protected]>
Add basic layout test coverage for File Picker on iOS
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (243523 => 243524)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-03-26 23:24:35 UTC (rev 243523)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2019-03-26 23:29:13 UTC (rev 243524)
@@ -800,6 +800,9 @@
if (session.isEphemeral()) {
NSURLSessionConfiguration *configuration = [NSURLSessionConfiguration ephemeralSessionConfiguration];
configuration._shouldSkipPreferredClientCertificateLookup = YES;
+#if HAVE(ALLOWS_SENSITIVE_LOGGING)
+ configuration._allowsSensitiveLogging = NO;
+#endif
return configuration;
}
return [NSURLSessionConfiguration defaultSessionConfiguration];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
