Title: [243538] trunk/Source/WebCore
- Revision
- 243538
- Author
- [email protected]
- Date
- 2019-03-27 05:14:07 -0700 (Wed, 27 Mar 2019)
Log Message
Build failure with gstreamer 1.12.5 if USE_GSTREAMER_GL is enabled
https://bugs.webkit.org/show_bug.cgi?id=196178
Reviewed by Xabier Rodriguez-Calvar.
The gst/gl/gl.h header needs to be included before
GraphicsContext3D.h to avoid declaration conflicts with
OpenGLShims.
Based on a patch from Mike Gorse <[email protected]>
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243537 => 243538)
--- trunk/Source/WebCore/ChangeLog 2019-03-27 11:34:53 UTC (rev 243537)
+++ trunk/Source/WebCore/ChangeLog 2019-03-27 12:14:07 UTC (rev 243538)
@@ -1,5 +1,21 @@
2019-03-27 Philippe Normand <[email protected]>
+ Build failure with gstreamer 1.12.5 if USE_GSTREAMER_GL is enabled
+ https://bugs.webkit.org/show_bug.cgi?id=196178
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ The gst/gl/gl.h header needs to be included before
+ GraphicsContext3D.h to avoid declaration conflicts with
+ OpenGLShims.
+
+ Based on a patch from Mike Gorse <[email protected]>
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ (WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
+
+2019-03-27 Philippe Normand <[email protected]>
+
[GStreamer] Remove the HLS queue buffering query hack
https://bugs.webkit.org/show_bug.cgi?id=196244
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (243537 => 243538)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2019-03-27 11:34:53 UTC (rev 243537)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2019-03-27 12:14:07 UTC (rev 243538)
@@ -29,7 +29,6 @@
#include "GStreamerCommon.h"
#include "GraphicsContext.h"
-#include "GraphicsContext3D.h"
#include "ImageGStreamer.h"
#include "ImageOrientation.h"
#include "IntRect.h"
@@ -118,6 +117,7 @@
#if USE(TEXTURE_MAPPER_GL)
#include "BitmapTextureGL.h"
#include "BitmapTexturePool.h"
+#include "GraphicsContext3D.h"
#include "TextureMapperContextAttributes.h"
#include "TextureMapperGL.h"
#include "TextureMapperPlatformLayerBuffer.h"
@@ -192,6 +192,9 @@
if (m_isMapped)
m_textureID = *reinterpret_cast<GLuint*>(m_videoFrame.data[0]);
} else
+#else
+ UNUSED_PARAM(flags);
+ UNUSED_PARAM(gstGLEnabled);
#endif // USE(GSTREAMER_GL)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
