Title: [243550] trunk
- Revision
- 243550
- Author
- [email protected]
- Date
- 2019-03-27 11:06:49 -0700 (Wed, 27 Mar 2019)
Log Message
REGRESSION (r242687): Fullscreen YouTube videos show blank white space at top
https://bugs.webkit.org/show_bug.cgi?id=196304
rdar://problem/49175760
Reviewed by Zalan Bujtas.
Source/WebCore:
repositionRelatedLayers() should not short-circuit when topContentInset is zero,
because topContentInset might be changing from non-zero to zero, and then we need
to move layers around.
Test: scrollingcoordinator/mac/top-content-inset-to-zero.html
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionRelatedLayers):
LayoutTests:
* scrollingcoordinator/mac/top-content-inset-to-zero-expected.html: Added.
* scrollingcoordinator/mac/top-content-inset-to-zero.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (243549 => 243550)
--- trunk/LayoutTests/ChangeLog 2019-03-27 17:59:32 UTC (rev 243549)
+++ trunk/LayoutTests/ChangeLog 2019-03-27 18:06:49 UTC (rev 243550)
@@ -1,3 +1,14 @@
+2019-03-27 Simon Fraser <[email protected]>
+
+ REGRESSION (r242687): Fullscreen YouTube videos show blank white space at top
+ https://bugs.webkit.org/show_bug.cgi?id=196304
+ rdar://problem/49175760
+
+ Reviewed by Zalan Bujtas.
+
+ * scrollingcoordinator/mac/top-content-inset-to-zero-expected.html: Added.
+ * scrollingcoordinator/mac/top-content-inset-to-zero.html: Added.
+
2019-03-27 Shawn Roberts <[email protected]>
http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html is a flaky failure
Added: trunk/LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero-expected.html (0 => 243550)
--- trunk/LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero-expected.html (rev 0)
+++ trunk/LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero-expected.html 2019-03-27 18:06:49 UTC (rev 243550)
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <style>
+ .box {
+ width: 100px;
+ height: 100px;
+ background-color: blue;
+ }
+
+ .fixed {
+ position: fixed;
+ top: 0;
+ left: 0;
+ }
+ </style>
+</head>
+<body>
+ <div class="fixed box"></div>
+</body>
+</html>
Added: trunk/LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero.html (0 => 243550)
--- trunk/LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero.html (rev 0)
+++ trunk/LayoutTests/scrollingcoordinator/mac/top-content-inset-to-zero.html 2019-03-27 18:06:49 UTC (rev 243550)
@@ -0,0 +1,43 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <script>
+ if (window.testRunner)
+ testRunner.waitUntilDone();
+
+ function doTest()
+ {
+ requestAnimationFrame(() => {
+ if (window.internals)
+ internals.setTopContentInset(50);
+
+ requestAnimationFrame(() => {
+ if (window.internals)
+ internals.setTopContentInset(0);
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+ });
+ });
+ }
+
+ window.addEventListener('load', doTest, false);
+ </script>
+ <style>
+ .box {
+ width: 100px;
+ height: 100px;
+ background-color: blue;
+ }
+
+ .fixed {
+ position: fixed;
+ top: 0;
+ left: 0;
+ }
+ </style>
+</head>
+<body>
+ <div class="fixed box"></div>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (243549 => 243550)
--- trunk/Source/WebCore/ChangeLog 2019-03-27 17:59:32 UTC (rev 243549)
+++ trunk/Source/WebCore/ChangeLog 2019-03-27 18:06:49 UTC (rev 243550)
@@ -1,3 +1,20 @@
+2019-03-27 Simon Fraser <[email protected]>
+
+ REGRESSION (r242687): Fullscreen YouTube videos show blank white space at top
+ https://bugs.webkit.org/show_bug.cgi?id=196304
+ rdar://problem/49175760
+
+ Reviewed by Zalan Bujtas.
+
+ repositionRelatedLayers() should not short-circuit when topContentInset is zero,
+ because topContentInset might be changing from non-zero to zero, and then we need
+ to move layers around.
+
+ Test: scrollingcoordinator/mac/top-content-inset-to-zero.html
+
+ * page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+ (WebCore::ScrollingTreeFrameScrollingNodeMac::repositionRelatedLayers):
+
2019-03-26 Simon Fraser <[email protected]>
[iOS WK2] Fixed elements in frames can be misplaced sometimes
Modified: trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm (243549 => 243550)
--- trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm 2019-03-27 17:59:32 UTC (rev 243549)
+++ trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm 2019-03-27 18:06:49 UTC (rev 243550)
@@ -211,7 +211,7 @@
m_counterScrollingLayer.get().position = layoutViewport.location();
float topContentInset = this->topContentInset();
- if (m_insetClipLayer && m_rootContentsLayer && topContentInset) {
+ if (m_insetClipLayer && m_rootContentsLayer) {
m_insetClipLayer.get().position = FloatPoint(m_insetClipLayer.get().position.x, FrameView::yPositionForInsetClipLayer(scrollPosition, topContentInset));
m_rootContentsLayer.get().position = FrameView::positionForRootContentLayer(scrollPosition, scrollOrigin(), topContentInset, headerHeight());
if (m_contentShadowLayer)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
