Title: [243595] trunk/Source/WebKit
- Revision
- 243595
- Author
- [email protected]
- Date
- 2019-03-27 18:02:05 -0700 (Wed, 27 Mar 2019)
Log Message
[ARKit] Black view when opening a 3D model usdz file in new tab
https://bugs.webkit.org/show_bug.cgi?id=196333
<rdar://problem/47693367>
Reviewed by Tim Horton.
When opening a new WKSystemPreviewView, we were exiting if there was no
presentingViewController. This code was unnecessary, and causing blank
content when opening a new tab.
* UIProcess/ios/WKSystemPreviewView.mm:
(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
Remove the code looking for a presentingViewController.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243594 => 243595)
--- trunk/Source/WebKit/ChangeLog 2019-03-28 00:58:38 UTC (rev 243594)
+++ trunk/Source/WebKit/ChangeLog 2019-03-28 01:02:05 UTC (rev 243595)
@@ -1,3 +1,19 @@
+2019-03-27 Dean Jackson <[email protected]>
+
+ [ARKit] Black view when opening a 3D model usdz file in new tab
+ https://bugs.webkit.org/show_bug.cgi?id=196333
+ <rdar://problem/47693367>
+
+ Reviewed by Tim Horton.
+
+ When opening a new WKSystemPreviewView, we were exiting if there was no
+ presentingViewController. This code was unnecessary, and causing blank
+ content when opening a new tab.
+
+ * UIProcess/ios/WKSystemPreviewView.mm:
+ (-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
+ Remove the code looking for a presentingViewController.
+
2019-03-27 Wenson Hsieh <[email protected]>
Need a way to include WebKitAdditions code in WebKit API headers
Modified: trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm (243594 => 243595)
--- trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm 2019-03-28 00:58:38 UTC (rev 243594)
+++ trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm 2019-03-28 01:02:05 UTC (rev 243595)
@@ -91,12 +91,6 @@
- (void)web_setContentProviderData:(NSData *)data suggestedFilename:(NSString *)filename
{
- RefPtr<WebKit::WebPageProxy> page = _webView->_page;
- UIViewController *presentingViewController = page->uiClient().presentingViewController();
-
- if (!presentingViewController)
- return;
-
_suggestedFilename = adoptNS([filename copy]);
_data = adoptNS([data copy]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
