Diff
Modified: trunk/Source/_javascript_Core/API/glib/JSCOptions.cpp (243602 => 243603)
--- trunk/Source/_javascript_Core/API/glib/JSCOptions.cpp 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/_javascript_Core/API/glib/JSCOptions.cpp 2019-03-28 14:18:38 UTC (rev 243603)
@@ -617,7 +617,7 @@
#define FOR_EACH_OPTION(type_, name_, defaultValue_, availability_, description_) \
if (Options::Availability::availability_ == Options::Availability::Normal \
|| Options::isAvailable(Options::name_##ID, Options::Availability::availability_)) { \
- type_ defaultValue; \
+ type_ defaultValue { }; \
auto optionType = jscOptionsType(defaultValue); \
if (function (#name_, optionType, description_, userData)) \
return; \
Modified: trunk/Source/_javascript_Core/ChangeLog (243602 => 243603)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-28 14:18:38 UTC (rev 243603)
@@ -1,3 +1,15 @@
+2019-03-28 Víctor Manuel Jáquez Leal <[email protected]>
+
+ Silence lot of warnings when compiling with clang
+ https://bugs.webkit.org/show_bug.cgi?id=196310
+
+ Reviewed by Michael Catanzaro.
+
+ Initialize variable with default constructor.
+
+ * API/glib/JSCOptions.cpp:
+ (jsc_options_foreach):
+
2019-03-27 Saam Barati <[email protected]>
validateOSREntryValue with Int52 should box the value being checked into double format
Modified: trunk/Source/WebCore/ChangeLog (243602 => 243603)
--- trunk/Source/WebCore/ChangeLog 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebCore/ChangeLog 2019-03-28 14:18:38 UTC (rev 243603)
@@ -1,3 +1,21 @@
+2019-03-28 Víctor Manuel Jáquez Leal <[email protected]>
+
+ Silence lot of warnings when compiling with clang
+ https://bugs.webkit.org/show_bug.cgi?id=196310
+
+ Reviewed by Michael Catanzaro.
+
+ No change in behavior.
+
+ * accessibility/AccessibilityObject.h: add missing override
+ clause.
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (webKitWebSrcChangeState): add missing format string to log.
+ * platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h: add
+ missing virtual destructor.
+ * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
+ add missing override clause and remove unused private member.
+
2019-03-28 Carlos Garcia Campos <[email protected]>
[FreeType] Incorrect application of glyph positioning in the Y direction
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (243602 => 243603)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.h 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h 2019-03-28 14:18:38 UTC (rev 243603)
@@ -937,7 +937,7 @@
#if HAVE(ACCESSIBILITY)
#if PLATFORM(GTK)
- AccessibilityObjectWrapper* wrapper() const;
+ AccessibilityObjectWrapper* wrapper() const override;
void setWrapper(AccessibilityObjectWrapper*);
#else
AccessibilityObjectWrapper* wrapper() const override { return m_wrapper.get(); }
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (243602 => 243603)
--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2019-03-28 14:18:38 UTC (rev 243603)
@@ -738,7 +738,7 @@
WebKitWebSrc* src = ""
#if GST_CHECK_VERSION(1, 14, 0)
- GST_DEBUG_OBJECT(src, gst_state_change_get_name(transition));
+ GST_DEBUG_OBJECT(src, "%s", gst_state_change_get_name(transition));
#endif
switch (transition) {
case GST_STATE_CHANGE_READY_TO_NULL:
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h (243602 => 243603)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h 2019-03-28 14:18:38 UTC (rev 243603)
@@ -68,6 +68,7 @@
class HolePunchClient {
public:
virtual void setVideoRectangle(const IntRect&) = 0;
+ virtual ~HolePunchClient() = 0;
};
void setHolePunchClient(std::unique_ptr<HolePunchClient>&& client) { m_holePunchClient = WTFMove(client); }
Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h (243602 => 243603)
--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h 2019-03-28 14:18:38 UTC (rev 243603)
@@ -124,7 +124,7 @@
const RefPtr<Nicosia::CompositionLayer>& compositionLayer() const;
private:
- bool isCoordinatedGraphicsLayer() const;
+ bool isCoordinatedGraphicsLayer() const override;
void updatePlatformLayer();
@@ -166,7 +166,6 @@
bool m_isPurging;
#endif
bool m_shouldUpdateVisibleRect: 1;
- bool m_shouldSyncLayerState: 1;
bool m_movingVisibleRect : 1;
bool m_pendingContentsScaleAdjustment : 1;
bool m_pendingVisibleRectAdjustment : 1;
Modified: trunk/Source/WebKit/ChangeLog (243602 => 243603)
--- trunk/Source/WebKit/ChangeLog 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebKit/ChangeLog 2019-03-28 14:18:38 UTC (rev 243603)
@@ -1,3 +1,15 @@
+2019-03-28 Víctor Manuel Jáquez Leal <[email protected]>
+
+ Silence lot of warnings when compiling with clang
+ https://bugs.webkit.org/show_bug.cgi?id=196310
+
+ Reviewed by Michael Catanzaro.
+
+ * UIProcess/API/glib/WebKitInjectedBundleClient.cpp: add missing
+ override clause.
+ * WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: add
+ missing override clause.
+
2019-03-27 Ryosuke Niwa <[email protected]>
[macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp (243602 => 243603)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp 2019-03-28 14:18:38 UTC (rev 243603)
@@ -131,7 +131,7 @@
ASSERT_NOT_REACHED();
}
- RefPtr<API::Object> getInjectedBundleInitializationUserData(WebProcessPool&)
+ RefPtr<API::Object> getInjectedBundleInitializationUserData(WebProcessPool&) override
{
GRefPtr<GVariant> data = ""
GUniquePtr<gchar> dataString(g_variant_print(data.get(), TRUE));
Modified: trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h (243602 => 243603)
--- trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h 2019-03-28 13:58:38 UTC (rev 243602)
+++ trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h 2019-03-28 14:18:38 UTC (rev 243603)
@@ -137,7 +137,7 @@
m_layerTreeHost.didDestroyGLContext();
}
- void resize(const WebCore::IntSize& size)
+ void resize(const WebCore::IntSize& size) override
{
if (m_layerTreeHost.m_surface)
m_layerTreeHost.m_surface->clientResize(size);
@@ -158,7 +158,7 @@
m_layerTreeHost.requestDisplayRefreshMonitorUpdate();
}
- void handleDisplayRefreshMonitorUpdate(bool hasBeenRescheduled)
+ void handleDisplayRefreshMonitorUpdate(bool hasBeenRescheduled) override
{
m_layerTreeHost.handleDisplayRefreshMonitorUpdate(hasBeenRescheduled);
}
