Title: [243610] trunk/Source/WebCore
- Revision
- 243610
- Author
- [email protected]
- Date
- 2019-03-28 11:05:13 -0700 (Thu, 28 Mar 2019)
Log Message
[MSE][GStreamer] Remove dead code in MediaPlayerPrivateGStreamer::doSeek()
https://bugs.webkit.org/show_bug.cgi?id=196352
Reviewed by Xabier Rodriguez-Calvar.
MediaPlayerPrivateGStreamerMSE overrides doSeek() and seek(), so this
branch is never reached.
This patch does not introduce behavior changes.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::doSeek):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243609 => 243610)
--- trunk/Source/WebCore/ChangeLog 2019-03-28 17:50:19 UTC (rev 243609)
+++ trunk/Source/WebCore/ChangeLog 2019-03-28 18:05:13 UTC (rev 243610)
@@ -1,3 +1,18 @@
+2019-03-28 Alicia Boya García <[email protected]>
+
+ [MSE][GStreamer] Remove dead code in MediaPlayerPrivateGStreamer::doSeek()
+ https://bugs.webkit.org/show_bug.cgi?id=196352
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ MediaPlayerPrivateGStreamerMSE overrides doSeek() and seek(), so this
+ branch is never reached.
+
+ This patch does not introduce behavior changes.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::doSeek):
+
2019-03-28 Simon Fraser <[email protected]>
[macOS WK2] Overlays on instagram.com are shifted if you click on a photo after scrolling
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (243609 => 243610)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-03-28 17:50:19 UTC (rev 243609)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-03-28 18:05:13 UTC (rev 243610)
@@ -591,11 +591,6 @@
// Default values for rate >= 0.
MediaTime startTime = position, endTime = MediaTime::invalidTime();
- // TODO: Should do more than that, need to notify the media source
- // and probably flush the pipeline at least.
- if (isMediaSource())
- return true;
-
if (rate < 0) {
startTime = MediaTime::zeroTime();
// If we are at beginning of media, start from the end to
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
