Title: [243624] trunk/JSTests
- Revision
- 243624
- Author
- [email protected]
- Date
- 2019-03-28 14:45:53 -0700 (Thu, 28 Mar 2019)
Log Message
[JSC] imports-oom.js intermittently fails
https://bugs.webkit.org/show_bug.cgi?id=196373
Reviewed by Saam Barati.
imports-oom.js ensures that a wasm module compilation / instantiation throws an OOM error instead of crashing when compiling / instantiating their entry points
with extremely low executable memory amount. And this test expects we at least once successfully compile, instantiate, and execute a wasm module to test that
wasm implementation is always throwing an OOM error. However, maybe due to wasm changes, the amount of executable memory consumed by wasm compilation is changed,
and now we may encounter an OOM error at the first compilation. Since imports-oom.js randomize the amount of executable memory used by the generated wasm module,
imports-oom.js intermittently fails when it first generates large wasm module which cannot be compiled.
This patch reduces the maxParams from 32 to 8 to reduce the size of randomly generated wasm module. Since we repeatedly generate wasm modules, this test soon encounter
an expected OOM error. But this avoids the situation that we get an OOM error when we compile a first wasm module.
* wasm/lowExecutableMemory/imports-oom.js:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (243623 => 243624)
--- trunk/JSTests/ChangeLog 2019-03-28 21:30:41 UTC (rev 243623)
+++ trunk/JSTests/ChangeLog 2019-03-28 21:45:53 UTC (rev 243624)
@@ -1,3 +1,21 @@
+2019-03-28 Yusuke Suzuki <[email protected]>
+
+ [JSC] imports-oom.js intermittently fails
+ https://bugs.webkit.org/show_bug.cgi?id=196373
+
+ Reviewed by Saam Barati.
+
+ imports-oom.js ensures that a wasm module compilation / instantiation throws an OOM error instead of crashing when compiling / instantiating their entry points
+ with extremely low executable memory amount. And this test expects we at least once successfully compile, instantiate, and execute a wasm module to test that
+ wasm implementation is always throwing an OOM error. However, maybe due to wasm changes, the amount of executable memory consumed by wasm compilation is changed,
+ and now we may encounter an OOM error at the first compilation. Since imports-oom.js randomize the amount of executable memory used by the generated wasm module,
+ imports-oom.js intermittently fails when it first generates large wasm module which cannot be compiled.
+
+ This patch reduces the maxParams from 32 to 8 to reduce the size of randomly generated wasm module. Since we repeatedly generate wasm modules, this test soon encounter
+ an expected OOM error. But this avoids the situation that we get an OOM error when we compile a first wasm module.
+
+ * wasm/lowExecutableMemory/imports-oom.js:
+
2019-03-27 Saam Barati <[email protected]>
validateOSREntryValue with Int52 should box the value being checked into double format
Modified: trunk/JSTests/wasm/lowExecutableMemory/imports-oom.js (243623 => 243624)
--- trunk/JSTests/wasm/lowExecutableMemory/imports-oom.js 2019-03-28 21:30:41 UTC (rev 243623)
+++ trunk/JSTests/wasm/lowExecutableMemory/imports-oom.js 2019-03-28 21:45:53 UTC (rev 243624)
@@ -3,7 +3,7 @@
const verbose = false;
const numFunctions = 2;
-const maxParams = 32;
+const maxParams = 8;
// This test starts running with a few bytes of executable memory available. Try
// to create and instantiate modules which have way more imports than anything
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
