Modified: trunk/Source/WebKit/ChangeLog (243639 => 243640)
--- trunk/Source/WebKit/ChangeLog 2019-03-29 04:42:42 UTC (rev 243639)
+++ trunk/Source/WebKit/ChangeLog 2019-03-29 04:57:11 UTC (rev 243640)
@@ -1,3 +1,19 @@
+2019-03-28 Timothy Hatcher <[email protected]>
+
+ CFDictionary encoder crashes on non-string keys.
+ https://bugs.webkit.org/show_bug.cgi?id=196388
+ rdar://problem/49339242
+
+ Reviewed by Ryosuke Niwa.
+
+ Allow non-string keys in CFDictionary encoding/decoding. Encode the correct
+ size for dictionaries and arrays when unknown keys or values are skipped.
+ Allow null array encoding and decoding like dictionary already allowed.
+
+ * Shared/cf/ArgumentCodersCF.cpp:
+ (IPC::encode):
+ (IPC::decode):
+
2019-03-28 John Wilander <[email protected]>
Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
Modified: trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp (243639 => 243640)
--- trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp 2019-03-29 04:42:42 UTC (rev 243639)
+++ trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp 2019-03-29 04:57:11 UTC (rev 243640)
@@ -31,6 +31,7 @@
#include "DataReference.h"
#include "Decoder.h"
#include "Encoder.h"
+#include <wtf/HashSet.h>
#include <wtf/ProcessPrivilege.h>
#include <wtf/Vector.h>
#include <wtf/cf/CFURLExtras.h>
@@ -326,16 +327,31 @@
void encode(Encoder& encoder, CFArrayRef array)
{
+ if (!array) {
+ encoder << true;
+ return;
+ }
+
+ encoder << false;
+
CFIndex size = CFArrayGetCount(array);
Vector<CFTypeRef, 32> values(size);
CFArrayGetValues(array, CFRangeMake(0, size), values.data());
- encoder << static_cast<uint64_t>(size);
+ HashSet<CFIndex> invalidIndicies;
+ for (CFIndex i = 0; i < size; ++i) {
+ // Ignore values we don't support.
+ ASSERT(typeFromCFTypeRef(values[i]) != Unknown);
+ if (typeFromCFTypeRef(values[i]) == Unknown)
+ invalidIndicies.add(i);
+ }
+ encoder << static_cast<uint64_t>(size - invalidIndicies.size());
+
for (CFIndex i = 0; i < size; ++i) {
- ASSERT(values[i]);
-
+ if (invalidIndicies.contains(i))
+ continue;
encode(encoder, values[i]);
}
}
@@ -342,6 +358,15 @@
bool decode(Decoder& decoder, RetainPtr<CFArrayRef>& result)
{
+ bool isNull = false;
+ if (!decoder.decode(isNull))
+ return false;
+
+ if (isNull) {
+ result = nullptr;
+ return true;
+ }
+
uint64_t size;
if (!decoder.decode(size))
return false;
@@ -414,6 +439,7 @@
encoder << true;
return;
}
+
encoder << false;
CFIndex size = CFDictionaryGetCount(dictionary);
@@ -422,18 +448,25 @@
CFDictionaryGetKeysAndValues(dictionary, keys.data(), values.data());
- encoder << static_cast<uint64_t>(size);
-
+ HashSet<CFTypeRef> invalidKeys;
for (CFIndex i = 0; i < size; ++i) {
ASSERT(keys[i]);
- ASSERT(CFGetTypeID(keys[i]) == CFStringGetTypeID());
ASSERT(values[i]);
- // Ignore values we don't recognize.
- if (typeFromCFTypeRef(values[i]) == Unknown)
+ // Ignore keys/values we don't support.
+ ASSERT(typeFromCFTypeRef(keys[i]) != Unknown);
+ ASSERT(typeFromCFTypeRef(values[i]) != Unknown);
+ if (typeFromCFTypeRef(keys[i]) == Unknown || typeFromCFTypeRef(values[i]) == Unknown)
+ invalidKeys.add(keys[i]);
+ }
+
+ encoder << static_cast<uint64_t>(size - invalidKeys.size());
+
+ for (CFIndex i = 0; i < size; ++i) {
+ if (invalidKeys.contains(keys[i]))
continue;
- encode(encoder, static_cast<CFStringRef>(keys[i]));
+ encode(encoder, keys[i]);
encode(encoder, values[i]);
}
}
@@ -443,6 +476,7 @@
bool isNull = false;
if (!decoder.decode(isNull))
return false;
+
if (isNull) {
result = nullptr;
return true;
@@ -454,8 +488,7 @@
RetainPtr<CFMutableDictionaryRef> dictionary = adoptCF(CFDictionaryCreateMutable(0, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
for (uint64_t i = 0; i < size; ++i) {
- // Try to decode the key name.
- RetainPtr<CFStringRef> key;
+ RetainPtr<CFTypeRef> key;
if (!decode(decoder, key))
return false;
