Title: [243648] trunk/Source/WebCore
- Revision
- 243648
- Author
- [email protected]
- Date
- 2019-03-29 10:44:14 -0700 (Fri, 29 Mar 2019)
Log Message
WebKitTestRunner crashes when running pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html
https://bugs.webkit.org/show_bug.cgi?id=196345
Patch by Antoine Quint <[email protected]> on 2019-03-29
Reviewed by Dean Jackson.
An enum used within a WTF::OptionSet needs to have only power-of-two values that are larger than 0.
* platform/TouchAction.h:
* rendering/style/StyleRareNonInheritedData.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (243647 => 243648)
--- trunk/Source/WebCore/ChangeLog 2019-03-29 16:11:02 UTC (rev 243647)
+++ trunk/Source/WebCore/ChangeLog 2019-03-29 17:44:14 UTC (rev 243648)
@@ -1,3 +1,15 @@
+2019-03-29 Antoine Quint <[email protected]>
+
+ WebKitTestRunner crashes when running pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html
+ https://bugs.webkit.org/show_bug.cgi?id=196345
+
+ Reviewed by Dean Jackson.
+
+ An enum used within a WTF::OptionSet needs to have only power-of-two values that are larger than 0.
+
+ * platform/TouchAction.h:
+ * rendering/style/StyleRareNonInheritedData.h:
+
2019-03-29 Michael Catanzaro <[email protected]>
HTMLInputElement::setEditingValue should not fail if renderer doesn't exist
Modified: trunk/Source/WebCore/platform/TouchAction.h (243647 => 243648)
--- trunk/Source/WebCore/platform/TouchAction.h 2019-03-29 16:11:02 UTC (rev 243647)
+++ trunk/Source/WebCore/platform/TouchAction.h 2019-03-29 17:44:14 UTC (rev 243648)
@@ -30,12 +30,12 @@
namespace WebCore {
enum class TouchAction : uint8_t {
- Auto = 0,
- None = 1 << 0,
- Manipulation = 1 << 1,
- PanX = 1 << 2,
- PanY = 1 << 3,
- PinchZoom = 1 << 4,
+ Auto = 1 << 0,
+ None = 1 << 1,
+ Manipulation = 1 << 2,
+ PanX = 1 << 3,
+ PanY = 1 << 4,
+ PinchZoom = 1 << 5,
};
}
Modified: trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h (243647 => 243648)
--- trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h 2019-03-29 16:11:02 UTC (rev 243647)
+++ trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h 2019-03-29 17:44:14 UTC (rev 243648)
@@ -175,7 +175,7 @@
std::unique_ptr<HashSet<String>> customPaintWatchedProperties;
#if ENABLE(POINTER_EVENTS)
- unsigned touchActions : 5; // TouchAction
+ unsigned touchActions : 6; // TouchAction
#endif
unsigned pageSizeType : 2; // PageSizeType
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes