Title: [243673] trunk
- Revision
- 243673
- Author
- [email protected]
- Date
- 2019-03-29 19:56:17 -0700 (Fri, 29 Mar 2019)
Log Message
[ContentChangeObserver] Expand DOM timer observation to 350ms
https://bugs.webkit.org/show_bug.cgi?id=196411
<rdar://problem/49391144>
Reviewed by Simon Fraser.
Source/WebCore:
imdb.com main page has 350ms hover intent timer to bring up the hover menus around the search bar.
Test: fast/events/touch/ios/content-observation/350ms-hover-intent.html
* page/ios/ContentChangeObserver.cpp:
LayoutTests:
* fast/events/touch/ios/content-observation/350ms-hover-intent-expected.txt: Added.
* fast/events/touch/ios/content-observation/350ms-hover-intent.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (243672 => 243673)
--- trunk/LayoutTests/ChangeLog 2019-03-30 01:30:16 UTC (rev 243672)
+++ trunk/LayoutTests/ChangeLog 2019-03-30 02:56:17 UTC (rev 243673)
@@ -1,3 +1,14 @@
+2019-03-29 Zalan Bujtas <[email protected]>
+
+ [ContentChangeObserver] Expand DOM timer observation to 350ms
+ https://bugs.webkit.org/show_bug.cgi?id=196411
+ <rdar://problem/49391144>
+
+ Reviewed by Simon Fraser.
+
+ * fast/events/touch/ios/content-observation/350ms-hover-intent-expected.txt: Added.
+ * fast/events/touch/ios/content-observation/350ms-hover-intent.html: Added.
+
2019-03-29 John Wilander <[email protected]>
Move WebResourceLoadStatisticsStore IPC calls from the UI process to the network process
Added: trunk/LayoutTests/fast/events/touch/ios/content-observation/350ms-hover-intent-expected.txt (0 => 243673)
--- trunk/LayoutTests/fast/events/touch/ios/content-observation/350ms-hover-intent-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/350ms-hover-intent-expected.txt 2019-03-30 02:56:17 UTC (rev 243673)
@@ -0,0 +1,2 @@
+PASS if 'clicked' text is not shown below.
+
Added: trunk/LayoutTests/fast/events/touch/ios/content-observation/350ms-hover-intent.html (0 => 243673)
--- trunk/LayoutTests/fast/events/touch/ios/content-observation/350ms-hover-intent.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/350ms-hover-intent.html 2019-03-30 02:56:17 UTC (rev 243673)
@@ -0,0 +1,59 @@
+<html>
+<head>
+<title>This tests the case when the visible content change happens on a 350ms timer.</title>
+<script src=""
+<style>
+#tapthis {
+ width: 400px;
+ height: 400px;
+ border: 1px solid green;
+}
+
+#becomesVisible {
+ display: none;
+ width: 100px;
+ height: 100px;
+ background-color: green;
+}
+</style>
+<script>
+async function test() {
+ if (!window.testRunner || !testRunner.runUIScript)
+ return;
+ if (window.internals)
+ internals.settings.setContentChangeObserverEnabled(true);
+
+ testRunner.waitUntilDone();
+ testRunner.dumpAsText();
+
+ let rect = tapthis.getBoundingClientRect();
+ let x = rect.left + rect.width / 2;
+ let y = rect.top + rect.height / 2;
+
+ await tapAtPoint(x, y);
+}
+</script>
+</head>
+<body _onload_="test()">
+<div id=tapthis>PASS if 'clicked' text is not shown below.</div>
+<div id=becomesVisible></div>
+<pre id=result></pre>
+<script>
+tapthis.addEventListener("mousemove", function( event ) {
+ setTimeout(function() {
+ becomesVisible.style.display = "block";
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 350);
+}, false);
+
+becomesVisible.addEventListener("click", function( event ) {
+ result.innerHTML = "clicked hidden";
+}, false);
+
+tapthis.addEventListener("click", function( event ) {
+ result.innerHTML = "clicked";
+}, false);
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (243672 => 243673)
--- trunk/Source/WebCore/ChangeLog 2019-03-30 01:30:16 UTC (rev 243672)
+++ trunk/Source/WebCore/ChangeLog 2019-03-30 02:56:17 UTC (rev 243673)
@@ -1,3 +1,17 @@
+2019-03-29 Zalan Bujtas <[email protected]>
+
+ [ContentChangeObserver] Expand DOM timer observation to 350ms
+ https://bugs.webkit.org/show_bug.cgi?id=196411
+ <rdar://problem/49391144>
+
+ Reviewed by Simon Fraser.
+
+ imdb.com main page has 350ms hover intent timer to bring up the hover menus around the search bar.
+
+ Test: fast/events/touch/ios/content-observation/350ms-hover-intent.html
+
+ * page/ios/ContentChangeObserver.cpp:
+
2019-03-29 John Wilander <[email protected]>
Move WebResourceLoadStatisticsStore IPC calls from the UI process to the network process
Modified: trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp (243672 => 243673)
--- trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp 2019-03-30 01:30:16 UTC (rev 243672)
+++ trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp 2019-03-30 02:56:17 UTC (rev 243673)
@@ -39,7 +39,7 @@
namespace WebCore {
-static const Seconds maximumDelayForTimers { 300_ms };
+static const Seconds maximumDelayForTimers { 350_ms };
static const Seconds maximumDelayForTransitions { 300_ms };
static bool isConsideredHidden(const Element& element)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
