Title: [243679] trunk/Source/WebCore
Revision
243679
Author
[email protected]
Date
2019-03-30 09:38:17 -0700 (Sat, 30 Mar 2019)

Log Message

Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline
https://bugs.webkit.org/show_bug.cgi?id=196419
<rdar://problem/49444023>

Reviewed by Devin Rousso.

* page/ResourceUsageThread.cpp:
(WebCore::ResourceUsageThread::addObserver):
We forgot to call the function that would setup platform state
allowing us to subtract out the sampling profiler thread.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (243678 => 243679)


--- trunk/Source/WebCore/ChangeLog	2019-03-30 14:09:23 UTC (rev 243678)
+++ trunk/Source/WebCore/ChangeLog	2019-03-30 16:38:17 UTC (rev 243679)
@@ -1,3 +1,16 @@
+2019-03-30  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline
+        https://bugs.webkit.org/show_bug.cgi?id=196419
+        <rdar://problem/49444023>
+
+        Reviewed by Devin Rousso.
+
+        * page/ResourceUsageThread.cpp:
+        (WebCore::ResourceUsageThread::addObserver):
+        We forgot to call the function that would setup platform state
+        allowing us to subtract out the sampling profiler thread.
+
 2019-03-30  Zalan Bujtas  <[email protected]>
 
         [ContentChangeObserver] Add iFrame elements to the list of "considered clickable" elements.

Modified: trunk/Source/WebCore/page/ResourceUsageThread.cpp (243678 => 243679)


--- trunk/Source/WebCore/page/ResourceUsageThread.cpp	2019-03-30 14:09:23 UTC (rev 243678)
+++ trunk/Source/WebCore/page/ResourceUsageThread.cpp	2019-03-30 16:38:17 UTC (rev 243679)
@@ -58,8 +58,10 @@
 
         resourceUsageThread.recomputeCollectionMode();
 
-        if (wasEmpty)
+        if (wasEmpty) {
+            resourceUsageThread.platformSaveStateBeforeStarting();
             resourceUsageThread.m_condition.notifyAll();
+        }
     }
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to