Title: [243717] trunk/Source/WebInspectorUI
- Revision
- 243717
- Author
- [email protected]
- Date
- 2019-04-01 15:35:50 -0700 (Mon, 01 Apr 2019)
Log Message
Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged node
https://bugs.webkit.org/show_bug.cgi?id=196271
<rdar://problem/49290676>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WI.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (243716 => 243717)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-04-01 21:57:13 UTC (rev 243716)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-04-01 22:35:50 UTC (rev 243717)
@@ -1,5 +1,18 @@
2019-04-01 Devin Rousso <[email protected]>
+ Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged node
+ https://bugs.webkit.org/show_bug.cgi?id=196271
+ <rdar://problem/49290676>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ObjectTreeBaseTreeElement.js:
+ (WI.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
+
+ * Localizations/en.lproj/localizedStrings.js:
+
+2019-04-01 Devin Rousso <[email protected]>
+
Web Inspector: Debugger: breakpoints don't populate in inspector2 on first load
https://bugs.webkit.org/show_bug.cgi?id=196063
<rdar://problem/49097787>
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (243716 => 243717)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-04-01 21:57:13 UTC (rev 243716)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-04-01 22:35:50 UTC (rev 243717)
@@ -283,7 +283,6 @@
localizedStrings["Copy Row"] = "Copy Row";
localizedStrings["Copy Selected"] = "Copy Selected";
localizedStrings["Copy Table"] = "Copy Table";
-localizedStrings["Copy as HTML"] = "Copy as HTML";
localizedStrings["Copy as cURL"] = "Copy as cURL";
localizedStrings["Could not fetch properties. Object may no longer exist."] = "Could not fetch properties. Object may no longer exist.";
localizedStrings["Count"] = "Count";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js (243716 => 243717)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js 2019-04-01 21:57:13 UTC (rev 243716)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js 2019-04-01 22:35:50 UTC (rev 243717)
@@ -242,27 +242,5 @@
}
return;
}
-
- if (resolvedValue.subtype === "node") {
- contextMenu.appendItem(WI.UIString("Copy as HTML"), function() {
- resolvedValue.pushNodeToFrontend(function(nodeId) {
- WI.domManager.nodeForId(nodeId).copyNode();
- });
- });
-
- contextMenu.appendItem(WI.UIString("Scroll Into View"), function() {
- function scrollIntoView() { this.scrollIntoViewIfNeeded(true); }
- resolvedValue.callFunction(scrollIntoView, undefined, false, function() {});
- });
-
- contextMenu.appendSeparator();
-
- contextMenu.appendItem(WI.UIString("Reveal in DOM Tree"), function() {
- resolvedValue.pushNodeToFrontend(function(nodeId) {
- WI.domManager.inspectElement(nodeId);
- });
- });
- return;
- }
}
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes