Diff
Modified: trunk/Source/WebCore/ChangeLog (102374 => 102375)
--- trunk/Source/WebCore/ChangeLog 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/ChangeLog 2011-12-08 21:15:29 UTC (rev 102375)
@@ -1,3 +1,25 @@
+2011-12-08 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
+ https://bugs.webkit.org/show_bug.cgi?id=74120
+
+ Reviewed by Pavel Feldman.
+
+ * bindings/js/ScriptCallStackFactory.cpp:
+ (WebCore::createScriptCallStackForInspector):
+ * bindings/js/ScriptCallStackFactory.h:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateParametersCheck):
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateFunctionCallback):
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjInternal::customArgsAndExceptionCallback):
+ * bindings/v8/ScriptCallStackFactory.cpp:
+ (WebCore::createScriptCallStackForInspector):
+ * bindings/v8/ScriptCallStackFactory.h:
+
2011-12-08 Adrienne Walker <[email protected]>
[chromium] Remove dead code in compositor
Modified: trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp (102374 => 102375)
--- trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.cpp 2011-12-08 21:15:29 UTC (rev 102375)
@@ -86,7 +86,7 @@
return ScriptCallStack::create(frames);
}
-PassRefPtr<ScriptCallStack> createScriptCallStack(JSC::ExecState* exec)
+PassRefPtr<ScriptCallStack> createScriptCallStackForInspector(JSC::ExecState* exec)
{
size_t maxStackSize = 1;
if (InspectorInstrumentation::hasFrontends()) {
Modified: trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.h (102374 => 102375)
--- trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.h 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/js/ScriptCallStackFactory.h 2011-12-08 21:15:29 UTC (rev 102375)
@@ -44,7 +44,7 @@
PassRefPtr<ScriptCallStack> createScriptCallStack(size_t maxStackSize, bool emptyStackIsAllowed);
PassRefPtr<ScriptCallStack> createScriptCallStack(JSC::ExecState*, size_t maxStackSize);
-PassRefPtr<ScriptCallStack> createScriptCallStack(JSC::ExecState*);
+PassRefPtr<ScriptCallStack> createScriptCallStackForInspector(JSC::ExecState*);
PassRefPtr<ScriptArguments> createScriptArguments(JSC::ExecState*, unsigned skipArgumentCount);
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (102374 => 102375)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-12-08 21:15:29 UTC (rev 102375)
@@ -2399,7 +2399,7 @@
if ($function->signature->extendedAttributes->{"CustomArgumentHandling"} and !$function->isStatic) {
push(@$outputArray, " RefPtr<ScriptArguments> scriptArguments(createScriptArguments(exec, $numParameters));\n");
- push(@$outputArray, " RefPtr<ScriptCallStack> callStack(createScriptCallStack(exec));\n");
+ push(@$outputArray, " RefPtr<ScriptCallStack> callStack(createScriptCallStackForInspector(exec));\n");
$implIncludes{"ScriptArguments.h"} = 1;
$implIncludes{"ScriptCallStack.h"} = 1;
$implIncludes{"ScriptCallStackFactory.h"} = 1;
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (102374 => 102375)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-12-08 21:15:29 UTC (rev 102375)
@@ -1396,7 +1396,7 @@
if ($function->signature->extendedAttributes->{"CustomArgumentHandling"}) {
push(@implContentDecls, <<END);
RefPtr<ScriptArguments> scriptArguments(createScriptArguments(args, $numParameters));
- RefPtr<ScriptCallStack> callStack(createScriptCallStack());
+ RefPtr<ScriptCallStack> callStack(createScriptCallStackForInspector());
if (!callStack)
return v8::Undefined();
END
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (102374 => 102375)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2011-12-08 21:15:29 UTC (rev 102375)
@@ -1290,7 +1290,7 @@
return throwVMError(exec, createTypeError(exec, "Not enough arguments"));
ExceptionCode ec = 0;
RefPtr<ScriptArguments> scriptArguments(createScriptArguments(exec, 1));
- RefPtr<ScriptCallStack> callStack(createScriptCallStack(exec));
+ RefPtr<ScriptCallStack> callStack(createScriptCallStackForInspector(exec));
log* intArg(tolog(MAYBE_MISSING_PARAMETER(exec, 0, MissingIsUndefined)));
if (exec->hadException())
return JSValue::encode(jsUndefined());
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (102374 => 102375)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-12-08 21:15:29 UTC (rev 102375)
@@ -858,7 +858,7 @@
ExceptionCode ec = 0;
{
RefPtr<ScriptArguments> scriptArguments(createScriptArguments(args, 1));
- RefPtr<ScriptCallStack> callStack(createScriptCallStack());
+ RefPtr<ScriptCallStack> callStack(createScriptCallStackForInspector());
if (!callStack)
return v8::Undefined();
EXCEPTION_BLOCK(log*, intArg, V8log::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, MissingIsUndefined)) ? V8log::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, MissingIsUndefined))) : 0);
Modified: trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.cpp (102374 => 102375)
--- trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.cpp 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.cpp 2011-12-08 21:15:29 UTC (rev 102375)
@@ -105,7 +105,7 @@
return createScriptCallStack(stackTrace, maxStackSize, emptyStackIsAllowed);
}
-PassRefPtr<ScriptCallStack> createScriptCallStack()
+PassRefPtr<ScriptCallStack> createScriptCallStackForInspector()
{
size_t maxStackSize = 1;
if (InspectorInstrumentation::hasFrontends()) {
Modified: trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.h (102374 => 102375)
--- trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.h 2011-12-08 21:11:44 UTC (rev 102374)
+++ trunk/Source/WebCore/bindings/v8/ScriptCallStackFactory.h 2011-12-08 21:15:29 UTC (rev 102375)
@@ -48,7 +48,7 @@
PassRefPtr<ScriptCallStack> createScriptCallStack(v8::Handle<v8::StackTrace>, size_t maxStackSize);
PassRefPtr<ScriptCallStack> createScriptCallStack(size_t maxStackSize, bool emptyStackIsAllowed = false);
-PassRefPtr<ScriptCallStack> createScriptCallStack();
+PassRefPtr<ScriptCallStack> createScriptCallStackForInspector();
PassRefPtr<ScriptArguments> createScriptArguments(const v8::Arguments& v8arguments, unsigned skipArgumentCount);
} // namespace WebCore
