Title: [243783] trunk/Tools
- Revision
- 243783
- Author
- [email protected]
- Date
- 2019-04-02 18:56:58 -0700 (Tue, 02 Apr 2019)
Log Message
[WK2] Add support for Window's beforeprint / afterprint events
https://bugs.webkit.org/show_bug.cgi?id=196478
<rdar://problem/49535124>
Unreviewed build fix for MSVC.
> WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
* WebKitTestRunner/TestController.cpp:
(WTR::printFrame): Use int and float literals.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (243782 => 243783)
--- trunk/Tools/ChangeLog 2019-04-03 01:55:38 UTC (rev 243782)
+++ trunk/Tools/ChangeLog 2019-04-03 01:56:58 UTC (rev 243783)
@@ -1,3 +1,18 @@
+2019-04-02 Fujii Hironori <[email protected]>
+
+ [WK2] Add support for Window's beforeprint / afterprint events
+ https://bugs.webkit.org/show_bug.cgi?id=196478
+ <rdar://problem/49535124>
+
+ Unreviewed build fix for MSVC.
+
+ > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
+
+ And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::printFrame): Use int and float literals.
+
2019-04-02 Aakash Jain <[email protected]>
[ews-build] Reassign bots to queues
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (243782 => 243783)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2019-04-03 01:55:38 UTC (rev 243782)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2019-04-03 01:56:58 UTC (rev 243783)
@@ -264,7 +264,7 @@
static void printFrame(WKPageRef page, WKFrameRef frame, const void*)
{
- WKPageBeginPrinting(page, frame, WKPrintInfo { 1.0, 21.0, 29.7 });
+ WKPageBeginPrinting(page, frame, WKPrintInfo { 1, 21, 29.7f });
WKPageEndPrinting(page);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
