Title: [243816] trunk/Source/WebInspectorUI
Revision
243816
Author
[email protected]
Date
2019-04-03 11:05:03 -0700 (Wed, 03 Apr 2019)

Log Message

Web Inspector: Uncaught Exception: TypeError: this._computedStyleSection.focus is not a function. (In 'this._computedStyleSection.focus()', 'this._computedStyleSection.focus' is undefined)
https://bugs.webkit.org/show_bug.cgi?id=192108
<rdar://problem/46685392>

Reviewed by Devin Rousso.

This patch fixes the uncaught exception. Tabbing to and from "Properties" section continues
working the same way as before the patch.

* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.focusLastSection): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (243815 => 243816)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-04-03 18:03:30 UTC (rev 243815)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-04-03 18:05:03 UTC (rev 243816)
@@ -1,3 +1,18 @@
+2019-04-03  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Uncaught Exception: TypeError: this._computedStyleSection.focus is not a function. (In 'this._computedStyleSection.focus()', 'this._computedStyleSection.focus' is undefined)
+        https://bugs.webkit.org/show_bug.cgi?id=192108
+        <rdar://problem/46685392>
+
+        Reviewed by Devin Rousso.
+
+        This patch fixes the uncaught exception. Tabbing to and from "Properties" section continues
+        working the same way as before the patch.
+
+        * UserInterface/Views/ComputedStyleDetailsPanel.js:
+        (WI.ComputedStyleDetailsPanel.prototype.focusFirstSection): Deleted.
+        (WI.ComputedStyleDetailsPanel.prototype.focusLastSection): Deleted.
+
 2019-04-02  Devin Rousso  <[email protected]>
 
         Web Inspector: Elements: DOM breakpoint icon should stroke when hovering selection area

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js (243815 => 243816)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js	2019-04-03 18:03:30 UTC (rev 243815)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js	2019-04-03 18:05:03 UTC (rev 243816)
@@ -78,16 +78,6 @@
             this._delegate.computedStyleDetailsPanelShowProperty(property);
     }
 
-    focusFirstSection()
-    {
-        this._computedStyleSection.focus();
-    }
-
-    focusLastSection()
-    {
-        this._variablesTextEditor.focus();
-    }
-
     // Protected
 
     initialLayout()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to