Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (243822 => 243823)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-04-03 20:13:42 UTC (rev 243822)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-04-03 20:27:12 UTC (rev 243823)
@@ -41,6 +41,8 @@
'mac-debug', 'mac-debug-wk1', 'mac-wk1', 'mac-wk2', 'style', 'webkitperl', 'webkitpy', 'win', 'wincairo', 'wpe']
ENABLED_QUEUES = ['api-ios', 'api-mac', 'webkitperl']
+ STEPS_TO_HIDE = ['Killed old processes', 'Configured build', '^OS:.*Xcode:']
+
def _build_bubble(self, patch, queue):
bubble = {
'name': queue,
@@ -120,8 +122,11 @@
return '[[' + datetime.datetime.fromtimestamp(time).isoformat() + 'Z]]'
def _steps_messages(self, build):
- return '\n'.join([step.state_string for step in build.step_set.all()])
+ return '\n'.join([step.state_string for step in build.step_set.all() if self._should_display_step(step)])
+ def _should_display_step(self, step):
+ return not filter(lambda step_to_hide: re.search(step_to_hide, step.state_string), StatusBubble.STEPS_TO_HIDE)
+
def _most_recent_step_message(self, build):
recent_step = build.step_set.last()
if not recent_step:
Modified: trunk/Tools/ChangeLog (243822 => 243823)
--- trunk/Tools/ChangeLog 2019-04-03 20:13:42 UTC (rev 243822)
+++ trunk/Tools/ChangeLog 2019-04-03 20:27:12 UTC (rev 243823)
@@ -1,5 +1,18 @@
2019-04-03 Aakash Jain <[email protected]>
+ [ews-app] Status bubble should not display certain infrastructure status messages
+ https://bugs.webkit.org/show_bug.cgi?id=196550
+
+ Reviewed by Lucas Forschler.
+
+ Do not display the steps which are un-needed for end-user. This information is still avaiable
+ if the user click on the bubble and look at the Buildbot build.
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._steps_messages):
+ (StatusBubble._should_display_step): Method to decide whether to display the step or not.
+
+2019-04-03 Aakash Jain <[email protected]>
+
[ews-build] Use https for sending data to ews-app
https://bugs.webkit.org/show_bug.cgi?id=196492
