Title: [243858] trunk/Tools
- Revision
- 243858
- Author
- [email protected]
- Date
- 2019-04-03 22:44:01 -0700 (Wed, 03 Apr 2019)
Log Message
The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
https://bugs.webkit.org/show_bug.cgi?id=196588
<rdar://problem/49365787>
Unreviewed build fix for Windows port.
error C3861: 'kill': identifier not found
* TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
(TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (243857 => 243858)
--- trunk/Tools/ChangeLog 2019-04-04 05:27:25 UTC (rev 243857)
+++ trunk/Tools/ChangeLog 2019-04-04 05:44:01 UTC (rev 243858)
@@ -1,3 +1,16 @@
+2019-04-03 Fujii Hironori <[email protected]>
+
+ The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
+ https://bugs.webkit.org/show_bug.cgi?id=196588
+ <rdar://problem/49365787>
+
+ Unreviewed build fix for Windows port.
+
+ error C3861: 'kill': identifier not found
+
+ * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
+ (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
+
2019-04-03 Aakash Jain <[email protected]>
[ews-build] Cancel build and similar operations should have authentication
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp (243857 => 243858)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp 2019-04-04 05:27:25 UTC (rev 243857)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp 2019-04-04 05:44:01 UTC (rev 243858)
@@ -133,7 +133,7 @@
while (!WKPageGetFocusedFrame(webView.page()))
Util::spinRunLoop(10);
- kill(WKPageGetProcessIdentifier(webView.page()), 9);
+ WKPageTerminate(webView.page());
Util::run(&calledCrashHandler);
}
@@ -163,7 +163,7 @@
while (!WKPageGetFrameSetLargestFrame(webView.page()))
Util::spinRunLoop(10);
- kill(WKPageGetProcessIdentifier(webView.page()), 9);
+ WKPageTerminate(webView.page());
Util::run(&calledCrashHandler);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes