Title: [243860] trunk/Source/WebKit
- Revision
- 243860
- Author
- [email protected]
- Date
- 2019-04-03 22:48:20 -0700 (Wed, 03 Apr 2019)
Log Message
[ATK] Don't touch accessibility tree in WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=193914
Reviewed by Michael Catanzaro.
Move it to dispatchDidFinishDocumentLoad, since we know we have the document at that point and we can create the
root accessibility object wrapper.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (243859 => 243860)
--- trunk/Source/WebKit/ChangeLog 2019-04-04 05:47:44 UTC (rev 243859)
+++ trunk/Source/WebKit/ChangeLog 2019-04-04 05:48:20 UTC (rev 243860)
@@ -1,3 +1,17 @@
+2019-04-03 Carlos Garcia Campos <[email protected]>
+
+ [ATK] Don't touch accessibility tree in WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld
+ https://bugs.webkit.org/show_bug.cgi?id=193914
+
+ Reviewed by Michael Catanzaro.
+
+ Move it to dispatchDidFinishDocumentLoad, since we know we have the document at that point and we can create the
+ root accessibility object wrapper.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
+ (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
+
2019-04-03 Simon Fraser <[email protected]>
Simplify some "programmaticScroll" code paths
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (243859 => 243860)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2019-04-04 05:47:44 UTC (rev 243859)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2019-04-04 05:48:20 UTC (rev 243860)
@@ -599,6 +599,11 @@
// Notify the UIProcess.
webPage->send(Messages::WebPageProxy::DidFinishDocumentLoadForFrame(m_frame->frameID(), navigationID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())));
+
+#if HAVE(ACCESSIBILITY) && PLATFORM(GTK)
+ // Ensure the accessibility hierarchy is updated.
+ webPage->updateAccessibilityTree();
+#endif
}
void WebFrameLoaderClient::dispatchDidFinishLoad()
@@ -1708,15 +1713,9 @@
webPage->injectedBundleLoaderClient().didClearWindowObjectForFrame(*webPage, *m_frame, world);
-
WebAutomationSessionProxy* automationSessionProxy = WebProcess::singleton().automationSessionProxy();
if (automationSessionProxy && world.isNormal())
automationSessionProxy->didClearWindowObjectForFrame(*m_frame);
-
-#if HAVE(ACCESSIBILITY) && PLATFORM(GTK)
- // Ensure the accessibility hierarchy is updated.
- webPage->updateAccessibilityTree();
-#endif
}
void WebFrameLoaderClient::dispatchGlobalObjectAvailable(DOMWrapperWorld& world)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
