Title: [243870] trunk/Tools
Revision
243870
Author
[email protected]
Date
2019-04-04 08:44:37 -0700 (Thu, 04 Apr 2019)

Log Message

Unreviewed, roll out r243858 which made tests time out.

Disable new API tests on Windows instead.

* TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (243869 => 243870)


--- trunk/Tools/ChangeLog	2019-04-04 15:41:07 UTC (rev 243869)
+++ trunk/Tools/ChangeLog	2019-04-04 15:44:37 UTC (rev 243870)
@@ -1,3 +1,12 @@
+2019-04-04  Chris Dumez  <[email protected]>
+
+        Unreviewed, roll out r243858 which made tests time out.
+
+        Disable new API tests on Windows instead.
+
+        * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
+        (TestWebKitAPI::TEST):
+
 2019-04-03  Carlos Garcia Campos  <[email protected]>
 
         [ATK] Cleanup WebPageAccessibilityObjectAtk

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp (243869 => 243870)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp	2019-04-04 15:41:07 UTC (rev 243869)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp	2019-04-04 15:44:37 UTC (rev 243870)
@@ -91,6 +91,8 @@
     Util::run(&loadAfterCrash);
 }
 
+#if !PLATFORM(WIN)
+
 static void nullJavaScriptCallback(WKSerializedScriptValueRef, WKErrorRef, void*)
 {
 }
@@ -133,7 +135,7 @@
     while (!WKPageGetFocusedFrame(webView.page()))
         Util::spinRunLoop(10);
 
-    WKPageTerminate(webView.page());
+    kill(WKPageGetProcessIdentifier(webView.page()), 9);
 
     Util::run(&calledCrashHandler);
 }
@@ -163,11 +165,13 @@
     while (!WKPageGetFrameSetLargestFrame(webView.page()))
         Util::spinRunLoop(10);
 
-    WKPageTerminate(webView.page());
+    kill(WKPageGetProcessIdentifier(webView.page()), 9);
 
     Util::run(&calledCrashHandler);
 }
 
+#endif // !PLATFORM(WIN)
+
 } // namespace TestWebKitAPI
 
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to