Title: [243874] branches/safari-607-branch/LayoutTests
- Revision
- 243874
- Author
- [email protected]
- Date
- 2019-04-04 10:16:31 -0700 (Thu, 04 Apr 2019)
Log Message
Cherry-pick r241307. rdar://problem/49610758
AX: Fix flaky accessibility/loading-iframe-sends-notification.html
https://bugs.webkit.org/show_bug.cgi?id=194546
Reviewed by Zalan Bujtas.
This test was relying on timing between load events being sent and accessibility events being sent.
We don't need to do that, we can more directly test this interplay.
* accessibility/loading-iframe-sends-notification-expected.txt:
* accessibility/loading-iframe-sends-notification.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@241307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607-branch/LayoutTests/ChangeLog (243873 => 243874)
--- branches/safari-607-branch/LayoutTests/ChangeLog 2019-04-04 16:52:02 UTC (rev 243873)
+++ branches/safari-607-branch/LayoutTests/ChangeLog 2019-04-04 17:16:31 UTC (rev 243874)
@@ -1,3 +1,34 @@
+2019-04-04 Ryan Haddad <[email protected]>
+
+ Cherry-pick r241307. rdar://problem/49610758
+
+ AX: Fix flaky accessibility/loading-iframe-sends-notification.html
+ https://bugs.webkit.org/show_bug.cgi?id=194546
+
+ Reviewed by Zalan Bujtas.
+
+ This test was relying on timing between load events being sent and accessibility events being sent.
+ We don't need to do that, we can more directly test this interplay.
+
+ * accessibility/loading-iframe-sends-notification-expected.txt:
+ * accessibility/loading-iframe-sends-notification.html:
+
+
+ git-svn-id: http://svn.webkit.org/repository/webkit/trunk@241307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-02-12 Chris Fleizach <[email protected]>
+
+ AX: Fix flaky accessibility/loading-iframe-sends-notification.html
+ https://bugs.webkit.org/show_bug.cgi?id=194546
+
+ Reviewed by Zalan Bujtas.
+
+ This test was relying on timing between load events being sent and accessibility events being sent.
+ We don't need to do that, we can more directly test this interplay.
+
+ * accessibility/loading-iframe-sends-notification-expected.txt:
+ * accessibility/loading-iframe-sends-notification.html:
+
2019-04-02 Kocsen Chung <[email protected]>
Cherry-pick r240492. rdar://problem/49539128
Modified: branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt (243873 => 243874)
--- branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt 2019-04-04 16:52:02 UTC (rev 243873)
+++ branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt 2019-04-04 17:16:31 UTC (rev 243874)
@@ -13,7 +13,6 @@
PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is false
Got notification on iframe.
PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is true
-PASS gotIframeNotification is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification.html (243873 => 243874)
--- branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification.html 2019-04-04 16:52:02 UTC (rev 243873)
+++ branches/safari-607-branch/LayoutTests/accessibility/loading-iframe-sends-notification.html 2019-04-04 17:16:31 UTC (rev 243874)
@@ -42,8 +42,6 @@
function runTest()
{
- window.gotIframeNotification = false;
-
if (window.accessibilityController) {
window.root = accessibilityController.rootElement;
@@ -59,24 +57,16 @@
return;
debug("Got notification on iframe.");
- gotIframeNotification = true;
// Check that the button within the iframe is now reachable from the root.
shouldBeTrue("findByAccessibleTitleSubstring(root, 'InnerButton') != null");
+ accessibilityController.removeNotificationListener();
+ finishJSTest();
});
}
window.iframeElement = document.getElementById("iframe");
- iframeElement.addEventListener("load", function() {
- window.setTimeout(function() {
- shouldBeTrue("gotIframeNotification");
- if (window.accessibilityController)
- accessibilityController.removeNotificationListener();
- finishJSTest();
- }, 10);
- }, false);
-
// Load content into the iframe. This will trigger the event
// handler above, which will check that the accessibility tree
// was updated with new content.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
