Title: [243878] trunk/LayoutTests
- Revision
- 243878
- Author
- [email protected]
- Date
- 2019-04-04 10:39:32 -0700 (Thu, 04 Apr 2019)
Log Message
[macOS WK1] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=189678
<rdar://problem/44621674>
Patch by Antoine Quint <[email protected]> on 2019-04-04
Reviewed by Dean Jackson.
We make the test sturdier by waiting for two rAFs instead of just one to wait until animations have been updated (one rAF)
and accelerated animations have been committed (two rAFs).
We also use the "transitioncancel" event to determine the transition has been interrupted rather than using a rAF callback.
* webanimations/accelerated-transition-interrupted-on-composited-element.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (243877 => 243878)
--- trunk/LayoutTests/ChangeLog 2019-04-04 17:36:20 UTC (rev 243877)
+++ trunk/LayoutTests/ChangeLog 2019-04-04 17:39:32 UTC (rev 243878)
@@ -1,3 +1,18 @@
+2019-04-04 Antoine Quint <[email protected]>
+
+ [macOS WK1] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is a flaky image failure
+ https://bugs.webkit.org/show_bug.cgi?id=189678
+ <rdar://problem/44621674>
+
+ Reviewed by Dean Jackson.
+
+ We make the test sturdier by waiting for two rAFs instead of just one to wait until animations have been updated (one rAF)
+ and accelerated animations have been committed (two rAFs).
+
+ We also use the "transitioncancel" event to determine the transition has been interrupted rather than using a rAF callback.
+
+ * webanimations/accelerated-transition-interrupted-on-composited-element.html:
+
2019-04-04 Diego Pino Garcia <[email protected]>
[WPE] Unreviewed gardening
Modified: trunk/LayoutTests/webanimations/accelerated-transition-interrupted-on-composited-element.html (243877 => 243878)
--- trunk/LayoutTests/webanimations/accelerated-transition-interrupted-on-composited-element.html 2019-04-04 17:36:20 UTC (rev 243877)
+++ trunk/LayoutTests/webanimations/accelerated-transition-interrupted-on-composited-element.html 2019-04-04 17:39:32 UTC (rev 243878)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ experimental:WebAnimationsCSSIntegrationEnabled=true ] -->
+<!DOCTYPE html>
<body>
<style>
div {
@@ -18,10 +18,19 @@
// Wait for a transition to start and abort it.
div.addEventListener("transitionstart", event => {
div.style.transition = "none";
- if (window.testRunner)
- requestAnimationFrame(() => testRunner.notifyDone());
});
+// When notified the transition was aborted, finish the test once we've ensured that animations
+// have been updated (one rAF) and that accelerated animations will have been committed (two rAFs).
+div.addEventListener("transitioncancel", event => {
+ if (window.testRunner) {
+ requestAnimationFrame(() => {
+ requestAnimationFrame(() => testRunner.notifyDone());
+ });
+ }
+});
+
+
// Initiate a transform transition.
setTimeout(() => {
div.style.transition = "transform 2s";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
