Title: [243922] trunk/Tools
- Revision
- 243922
- Author
- [email protected]
- Date
- 2019-04-04 17:49:40 -0700 (Thu, 04 Apr 2019)
Log Message
Use a correct LC_RPATH when building with ASan
https://bugs.webkit.org/show_bug.cgi?id=196576
Reviewed by David Kilzer.
* asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
so that ../Frameworks is checked. This is simpler and more reliable than updating
each SPC service xcconfig.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (243921 => 243922)
--- trunk/Tools/ChangeLog 2019-04-05 00:31:41 UTC (rev 243921)
+++ trunk/Tools/ChangeLog 2019-04-05 00:49:40 UTC (rev 243922)
@@ -1,3 +1,14 @@
+2019-04-04 Alexey Proskuryakov <[email protected]>
+
+ Use a correct LC_RPATH when building with ASan
+ https://bugs.webkit.org/show_bug.cgi?id=196576
+
+ Reviewed by David Kilzer.
+
+ * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
+ so that ../Frameworks is checked. This is simpler and more reliable than updating
+ each SPC service xcconfig.
+
2019-04-04 Aakash Jain <[email protected]>
Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
Modified: trunk/Tools/asan/asan.xcconfig (243921 => 243922)
--- trunk/Tools/asan/asan.xcconfig 2019-04-05 00:31:41 UTC (rev 243921)
+++ trunk/Tools/asan/asan.xcconfig 2019-04-05 00:49:40 UTC (rev 243922)
@@ -17,3 +17,7 @@
ASAN_OTHER_CFLAGS = -fno-omit-frame-pointer -g;
ASAN_OTHER_CPLUSPLUSFLAGS = $(ASAN_OTHER_CFLAGS);
+
+// Workaround for rdar://problem/49498092
+OTHER_LDFLAGS = $(inherited) $(WK_LDFLAGS_ASAN_$(ENABLE_ADDRESS_SANITIZER));
+WK_LDFLAGS_ASAN_YES = -Wl,-rpath,@executable_path/../Frameworks;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
