Title: [243955] trunk
- Revision
- 243955
- Author
- [email protected]
- Date
- 2019-04-05 17:05:32 -0700 (Fri, 05 Apr 2019)
Log Message
Unreviewed, rolling out r243665.
Caused iOS JSC tests to exit with an exception.
Reverted changeset:
"Assertion failed in JSC::createError"
https://bugs.webkit.org/show_bug.cgi?id=196305
https://trac.webkit.org/changeset/243665
Modified Paths
Removed Paths
Diff
Modified: trunk/JSTests/ChangeLog (243954 => 243955)
--- trunk/JSTests/ChangeLog 2019-04-06 00:03:46 UTC (rev 243954)
+++ trunk/JSTests/ChangeLog 2019-04-06 00:05:32 UTC (rev 243955)
@@ -1,3 +1,15 @@
+2019-04-05 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r243665.
+
+ Caused iOS JSC tests to exit with an exception.
+
+ Reverted changeset:
+
+ "Assertion failed in JSC::createError"
+ https://bugs.webkit.org/show_bug.cgi?id=196305
+ https://trac.webkit.org/changeset/243665
+
2019-04-05 Yusuke Suzuki <[email protected]>
SIGSEGV in JSC::BytecodeGenerator::addStringConstant
Deleted: trunk/JSTests/stress/create-error-out-of-memory-rope-string-2.js (243954 => 243955)
--- trunk/JSTests/stress/create-error-out-of-memory-rope-string-2.js 2019-04-06 00:03:46 UTC (rev 243954)
+++ trunk/JSTests/stress/create-error-out-of-memory-rope-string-2.js 2019-04-06 00:05:32 UTC (rev 243955)
@@ -1,12 +0,0 @@
-function assert(a, message) {
- if (!a)
- throw new Error(message);
-}
-
-try {
- const var_1 = 'a'.padStart(2147483648 - 1);
- new var_1();
- assert(false, `Should throw OOM error`);
-} catch (error) {
- assert(error.message == "Out of memory", "Expected OutOfMemoryError, but got: " + error);
-}
Modified: trunk/Source/_javascript_Core/ChangeLog (243954 => 243955)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-06 00:03:46 UTC (rev 243954)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-06 00:05:32 UTC (rev 243955)
@@ -1,3 +1,15 @@
+2019-04-05 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r243665.
+
+ Caused iOS JSC tests to exit with an exception.
+
+ Reverted changeset:
+
+ "Assertion failed in JSC::createError"
+ https://bugs.webkit.org/show_bug.cgi?id=196305
+ https://trac.webkit.org/changeset/243665
+
2019-04-05 Yusuke Suzuki <[email protected]>
SIGSEGV in JSC::BytecodeGenerator::addStringConstant
Modified: trunk/Source/_javascript_Core/runtime/ExceptionHelpers.cpp (243954 => 243955)
--- trunk/Source/_javascript_Core/runtime/ExceptionHelpers.cpp 2019-04-06 00:03:46 UTC (rev 243954)
+++ trunk/Source/_javascript_Core/runtime/ExceptionHelpers.cpp 2019-04-06 00:05:32 UTC (rev 243955)
@@ -275,7 +275,8 @@
auto scope = DECLARE_CATCH_SCOPE(vm);
String valueDescription = errorDescriptionForValue(exec, value);
- if (scope.exception() || !valueDescription) {
+ ASSERT(scope.exception() || !!valueDescription);
+ if (!valueDescription) {
scope.clearException();
return createOutOfMemoryError(exec);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
