Title: [243964] trunk/Source/WebInspectorUI
- Revision
- 243964
- Author
- [email protected]
- Date
- 2019-04-06 19:54:58 -0700 (Sat, 06 Apr 2019)
Log Message
REGRESSION(r237196): Web Inspector: Computed panel shouldn't update when it isn't visible
https://bugs.webkit.org/show_bug.cgi?id=196667
<rdar://problem/49664912>
Reviewed by Timothy Hatcher.
Explicitly define `hidden` and `shown` methods instead of relying on SidebarPanel's `visible` getter.
* UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype.visibilityDidChange): Deleted.
(WI.GeneralStyleDetailsSidebarPanel.prototype.hidden): Added.
(WI.GeneralStyleDetailsSidebarPanel.prototype.shown): Added.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (243963 => 243964)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-04-07 02:25:36 UTC (rev 243963)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-04-07 02:54:58 UTC (rev 243964)
@@ -1,3 +1,18 @@
+2019-04-06 Nikita Vasilyev <[email protected]>
+
+ REGRESSION(r237196): Web Inspector: Computed panel shouldn't update when it isn't visible
+ https://bugs.webkit.org/show_bug.cgi?id=196667
+ <rdar://problem/49664912>
+
+ Reviewed by Timothy Hatcher.
+
+ Explicitly define `hidden` and `shown` methods instead of relying on SidebarPanel's `visible` getter.
+
+ * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
+ (WI.GeneralStyleDetailsSidebarPanel.prototype.visibilityDidChange): Deleted.
+ (WI.GeneralStyleDetailsSidebarPanel.prototype.hidden): Added.
+ (WI.GeneralStyleDetailsSidebarPanel.prototype.shown): Added.
+
2019-04-05 Devin Rousso <[email protected]>
Web Inspector: TestSuite test cases should have their own timeout to ensure tests fail with output instead of timeout by test runner
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (243963 => 243964)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2019-04-07 02:25:36 UTC (rev 243963)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2019-04-07 02:54:58 UTC (rev 243964)
@@ -45,20 +45,24 @@
return nodeToInspect.nodeType() === Node.ELEMENT_NODE;
}
- visibilityDidChange()
+ hidden()
{
- super.visibilityDidChange();
+ super.hidden();
+ if (this._panel)
+ this._panel.hidden();
+ }
+
+ shown()
+ {
+ super.shown();
+
if (!this._panel)
return;
- if (!this.visible) {
- this._panel.hidden();
- return;
- }
+ console.assert(this.visible, `Shown panel ${this._identifier} must be visible.`);
this._updateNoForcedPseudoClassesScrollOffset();
-
this._panel.shown();
this._panel.markAsNeedsRefresh(this.domNode);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
