Title: [243987] releases/WebKitGTK/webkit-2.24/Source/WebKit
- Revision
- 243987
- Author
- carlo...@webkit.org
- Date
- 2019-04-08 03:15:23 -0700 (Mon, 08 Apr 2019)
Log Message
Merge r243796 - [CoordinatedGraphics] Hidden pages are not suspended after a web view resize
https://bugs.webkit.org/show_bug.cgi?id=196487
Reviewed by Žan Doberšek.
When resizing the window, the hidden tabs are updated too, to avoid flickering or getting the old size when
switching tabs. For that we need to resume painting but we are not suspending it again after the update.
* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState): Suspend the painting again after a
synchronous update if needed.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/WebKit/ChangeLog (243986 => 243987)
--- releases/WebKitGTK/webkit-2.24/Source/WebKit/ChangeLog 2019-04-08 10:15:21 UTC (rev 243986)
+++ releases/WebKitGTK/webkit-2.24/Source/WebKit/ChangeLog 2019-04-08 10:15:23 UTC (rev 243987)
@@ -1,3 +1,17 @@
+2019-04-03 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [CoordinatedGraphics] Hidden pages are not suspended after a web view resize
+ https://bugs.webkit.org/show_bug.cgi?id=196487
+
+ Reviewed by Žan Doberšek.
+
+ When resizing the window, the hidden tabs are updated too, to avoid flickering or getting the old size when
+ switching tabs. For that we need to resume painting but we are not suspending it again after the update.
+
+ * WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+ (WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState): Suspend the painting again after a
+ synchronous update if needed.
+
2019-03-25 Fujii Hironori <hironori.fu...@sony.com>
[Coordinated Graphics][WinCairo] ASSERTION FAILED: state.id == m_nicosia.state.id
Modified: releases/WebKitGTK/webkit-2.24/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (243986 => 243987)
--- releases/WebKitGTK/webkit-2.24/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2019-04-08 10:15:21 UTC (rev 243986)
+++ releases/WebKitGTK/webkit-2.24/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2019-04-08 10:15:23 UTC (rev 243987)
@@ -411,10 +411,13 @@
if (respondImmediately) {
// Make sure to resume painting if we're supposed to respond immediately, otherwise we'll just
// send back an empty UpdateInfo struct.
+ bool wasSuspended = m_isPaintingSuspended;
if (m_isPaintingSuspended)
resumePainting();
sendDidUpdateBackingStoreState();
+ if (wasSuspended)
+ suspendPainting();
}
m_inUpdateBackingStoreState = false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
