Title: [244074] trunk/Source/WebCore
- Revision
- 244074
- Author
- [email protected]
- Date
- 2019-04-09 03:21:03 -0700 (Tue, 09 Apr 2019)
Log Message
Initialize trackTypeAsString for call to GST_INFO_OBJECT() in TrackType::Text
https://bugs.webkit.org/show_bug.cgi?id=196350
Patch by Eike Rathke <[email protected]> on 2019-04-09
Reviewed by Xabier Rodriguez-Calvar.
trackTypeAsString was uninitialized in the
TrackPrivateBaseGStreamer::TrackType::Text case when calling
GST_INFO_OBJECT().
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::enableTrack):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244073 => 244074)
--- trunk/Source/WebCore/ChangeLog 2019-04-09 09:48:21 UTC (rev 244073)
+++ trunk/Source/WebCore/ChangeLog 2019-04-09 10:21:03 UTC (rev 244074)
@@ -1,3 +1,17 @@
+2019-04-09 Eike Rathke <[email protected]>
+
+ Initialize trackTypeAsString for call to GST_INFO_OBJECT() in TrackType::Text
+ https://bugs.webkit.org/show_bug.cgi?id=196350
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ trackTypeAsString was uninitialized in the
+ TrackPrivateBaseGStreamer::TrackType::Text case when calling
+ GST_INFO_OBJECT().
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
+
2019-04-09 Carlos Garcia Campos <[email protected]>
[ATK] Cleanup WebKitAccessibleHyperlink
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (244073 => 244074)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-04-09 09:48:21 UTC (rev 244073)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-04-09 10:21:03 UTC (rev 244074)
@@ -813,13 +813,13 @@
selectedStreams.append(m_currentTextStreamId);
break;
case TrackPrivateBaseGStreamer::TrackType::Text:
+ propertyName = "current-text";
+ trackTypeAsString = "text";
if (!selectedStreamId.isEmpty() && selectedStreamId == m_currentTextStreamId) {
GST_INFO_OBJECT(pipeline(), "%s stream: %s already selected, not doing anything.", trackTypeAsString, selectedStreamId.utf8().data());
return;
}
- propertyName = "current-text";
- trackTypeAsString = "text";
if (!m_currentAudioStreamId.isEmpty())
selectedStreams.append(m_currentAudioStreamId);
if (!m_currentVideoStreamId.isEmpty())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
