Title: [244082] trunk/LayoutTests
- Revision
- 244082
- Author
- [email protected]
- Date
- 2019-04-09 10:50:11 -0700 (Tue, 09 Apr 2019)
Log Message
[ Mac ] REGRESSION (r237587) Layout Test compositing/visible-rect/animated-from-none.html is flaky text diff failure
https://bugs.webkit.org/show_bug.cgi?id=194798
<rdar://problem/48181898>
Reviewed by Dean Jackson.
When using the Web Animations engine, the best way to run code as an animation start is to use the "ready" promise, whereas
DOM events are dispatched asynchronously and, in the case of this test, might have an animation progress that is greater
than 0 and yield an animated transform that isn't quite the identity matrix.
* compositing/visible-rect/animated-from-none.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (244081 => 244082)
--- trunk/LayoutTests/ChangeLog 2019-04-09 16:57:22 UTC (rev 244081)
+++ trunk/LayoutTests/ChangeLog 2019-04-09 17:50:11 UTC (rev 244082)
@@ -1,3 +1,17 @@
+2019-04-09 Antoine Quint <[email protected]>
+
+ [ Mac ] REGRESSION (r237587) Layout Test compositing/visible-rect/animated-from-none.html is flaky text diff failure
+ https://bugs.webkit.org/show_bug.cgi?id=194798
+ <rdar://problem/48181898>
+
+ Reviewed by Dean Jackson.
+
+ When using the Web Animations engine, the best way to run code as an animation start is to use the "ready" promise, whereas
+ DOM events are dispatched asynchronously and, in the case of this test, might have an animation progress that is greater
+ than 0 and yield an animated transform that isn't quite the identity matrix.
+
+ * compositing/visible-rect/animated-from-none.html:
+
2019-04-09 Jer Noble <[email protected]>
Add test for fix of #196095
Modified: trunk/LayoutTests/compositing/visible-rect/animated-from-none.html (244081 => 244082)
--- trunk/LayoutTests/compositing/visible-rect/animated-from-none.html 2019-04-09 16:57:22 UTC (rev 244081)
+++ trunk/LayoutTests/compositing/visible-rect/animated-from-none.html 2019-04-09 17:50:11 UTC (rev 244082)
@@ -34,16 +34,15 @@
function doTest()
{
- let animated = document.getElementById('animated');
- animated.addEventListener('webkitAnimationStart', function() {
+ const animated = document.getElementById('animated');
+ animated.classList.add('animating');
+ animated.getAnimations()[0].ready.then(() => {
if (window.internals)
document.getElementById('layers').innerText = internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS)
if (window.testRunner)
testRunner.notifyDone();
- }, false);
-
- animated.classList.add('animating');
+ });
}
window.addEventListener('load', doTest, false);
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
