Title: [244106] trunk/Tools
- Revision
- 244106
- Author
- [email protected]
- Date
- 2019-04-10 01:00:41 -0700 (Wed, 10 Apr 2019)
Log Message
[WinCairo][MiniBrowser] Pull down menu "Disable _javascript_" doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=196727
Patch by Takashi Komori <[email protected]> on 2019-04-10
Reviewed by Fujii Hironori.
* MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::create):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (244105 => 244106)
--- trunk/Tools/ChangeLog 2019-04-10 07:59:14 UTC (rev 244105)
+++ trunk/Tools/ChangeLog 2019-04-10 08:00:41 UTC (rev 244106)
@@ -1,3 +1,13 @@
+2019-04-10 Takashi Komori <[email protected]>
+
+ [WinCairo][MiniBrowser] Pull down menu "Disable _javascript_" doesn't work.
+ https://bugs.webkit.org/show_bug.cgi?id=196727
+
+ Reviewed by Fujii Hironori.
+
+ * MiniBrowser/win/WebKitBrowserWindow.cpp:
+ (WebKitBrowserWindow::create):
+
2019-04-09 Aakash Jain <[email protected]>
[ews-build] Add unit tests for PrintConfiguration
Modified: trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp (244105 => 244106)
--- trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2019-04-10 07:59:14 UTC (rev 244105)
+++ trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2019-04-10 08:00:41 UTC (rev 244106)
@@ -106,16 +106,21 @@
Ref<BrowserWindow> WebKitBrowserWindow::create(HWND mainWnd, HWND urlBarWnd, bool, bool)
{
- auto conf = WKPageConfigurationCreate();
+ auto conf = adoptWK(WKPageConfigurationCreate());
- auto prefs = WKPreferencesCreate();
- WKPreferencesSetDeveloperExtrasEnabled(prefs, true);
- WKPageConfigurationSetPreferences(conf, prefs);
+ auto prefs = adoptWK(WKPreferencesCreate());
- auto context = WKContextCreateWithConfiguration(nullptr);
- WKPageConfigurationSetContext(conf, context);
+ auto pageGroup = adoptWK(WKPageGroupCreateWithIdentifier(createWKString("WinMiniBrowser").get()));
+ WKPageConfigurationSetPageGroup(conf.get(), pageGroup.get());
+ WKPageGroupSetPreferences(pageGroup.get(), prefs.get());
- return adoptRef(*new WebKitBrowserWindow(conf, mainWnd, urlBarWnd));
+ WKPreferencesSetDeveloperExtrasEnabled(prefs.get(), true);
+ WKPageConfigurationSetPreferences(conf.get(), prefs.get());
+
+ auto context =adoptWK(WKContextCreateWithConfiguration(nullptr));
+ WKPageConfigurationSetContext(conf.get(), context.get());
+
+ return adoptRef(*new WebKitBrowserWindow(conf.get(), mainWnd, urlBarWnd));
}
WebKitBrowserWindow::WebKitBrowserWindow(WKPageConfigurationRef conf, HWND mainWnd, HWND urlBarWnd)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
