Title: [244230] trunk/Source/WebKit
- Revision
- 244230
- Author
- drou...@apple.com
- Date
- 2019-04-12 13:46:55 -0700 (Fri, 12 Apr 2019)
Log Message
WebDriver: evaluating _javascript_ shouldn't fail if a dialog is shown
https://bugs.webkit.org/show_bug.cgi?id=196847
<rdar://problem/49609396>
Reviewed by Brian Burg.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::willShowJavaScriptDialog):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244229 => 244230)
--- trunk/Source/WebKit/ChangeLog 2019-04-12 20:37:38 UTC (rev 244229)
+++ trunk/Source/WebKit/ChangeLog 2019-04-12 20:46:55 UTC (rev 244230)
@@ -1,3 +1,14 @@
+2019-04-12 Devin Rousso <drou...@apple.com>
+
+ WebDriver: evaluating _javascript_ shouldn't fail if a dialog is shown
+ https://bugs.webkit.org/show_bug.cgi?id=196847
+ <rdar://problem/49609396>
+
+ Reviewed by Brian Burg.
+
+ * UIProcess/Automation/WebAutomationSession.cpp:
+ (WebKit::WebAutomationSession::willShowJavaScriptDialog):
+
2019-04-12 Ross Kirsling <ross.kirsl...@sony.com>
WebKit should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (244229 => 244230)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2019-04-12 20:37:38 UTC (rev 244229)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2019-04-12 20:46:55 UTC (rev 244230)
@@ -652,10 +652,9 @@
}
if (!m_evaluateJavaScriptFunctionCallbacks.isEmpty()) {
- Inspector::ErrorString unexpectedAlertOpenError = STRING_FOR_PREDEFINED_ERROR_NAME(UnexpectedAlertOpen);
for (auto key : copyToVector(m_evaluateJavaScriptFunctionCallbacks.keys())) {
auto callback = m_evaluateJavaScriptFunctionCallbacks.take(key);
- callback->sendFailure(unexpectedAlertOpenError);
+ callback->sendSuccess(emptyString());
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
