Title: [244270] trunk/Source/WebInspectorUI
- Revision
- 244270
- Author
- [email protected]
- Date
- 2019-04-15 10:29:26 -0700 (Mon, 15 Apr 2019)
Log Message
Web Inspector: Uncaught Exception: Can't find variable: WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=196874
<rdar://problem/49858912>
Reviewed by Timothy Hatcher.
* UserInterface/Models/Recording.js:
(WI.Recording.prototype.createContext):
* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.prototype.process.getContent):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (244269 => 244270)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-04-15 17:27:40 UTC (rev 244269)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-04-15 17:29:26 UTC (rev 244270)
@@ -1,5 +1,19 @@
2019-04-15 Devin Rousso <[email protected]>
+ Web Inspector: Uncaught Exception: Can't find variable: WebGL2RenderingContext
+ https://bugs.webkit.org/show_bug.cgi?id=196874
+ <rdar://problem/49858912>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/Recording.js:
+ (WI.Recording.prototype.createContext):
+
+ * UserInterface/Models/RecordingAction.js:
+ (WI.RecordingAction.prototype.process.getContent):
+
+2019-04-15 Devin Rousso <[email protected]>
+
Web Inspector: sidebar panels shouldn't be added as subviews unless visible
https://bugs.webkit.org/show_bug.cgi?id=196888
<rdar://problem/49870659>
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Recording.js (244269 => 244270)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Recording.js 2019-04-15 17:27:40 UTC (rev 244269)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Recording.js 2019-04-15 17:29:26 UTC (rev 244270)
@@ -451,7 +451,7 @@
if (this._type === WI.Recording.Type.Canvas2D)
return createCanvasContext("2d");
- if (this._type === WI.Recording.Type.BitmapRenderer)
+ if (this._type === WI.Recording.Type.CanvasBitmapRenderer)
return createCanvasContext("bitmaprenderer");
if (this._type === WI.Recording.Type.CanvasWebGL)
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js (244269 => 244270)
--- trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js 2019-04-15 17:27:40 UTC (rev 244269)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/RecordingAction.js 2019-04-15 17:29:26 UTC (rev 244270)
@@ -211,7 +211,7 @@
if (context instanceof CanvasRenderingContext2D)
return context.getImageData(0, 0, context.canvas.width, context.canvas.height).data;
- if (context instanceof WebGLRenderingContext || context instanceof WebGL2RenderingContext) {
+ if (context instanceof WebGLRenderingContext || (window.WebGL2RenderingContext && context instanceof WebGL2RenderingContext)) {
let pixels = new Uint8Array(context.drawingBufferWidth * context.drawingBufferHeight * 4);
context.readPixels(0, 0, context.canvas.width, context.canvas.height, context.RGBA, context.UNSIGNED_BYTE, pixels);
return pixels;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
