Title: [244320] trunk/Source/WebCore
- Revision
- 244320
- Author
- [email protected]
- Date
- 2019-04-15 18:55:50 -0700 (Mon, 15 Apr 2019)
Log Message
Fix logic flow for error log
https://bugs.webkit.org/show_bug.cgi?id=196933
Patch by Eike Rathke <[email protected]> on 2019-04-15
Reviewed by Alexey Proskuryakov.
Missing block braces logged an error always, not just
if (actionIfInvalid == Complain).
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSafeToLoadURL):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244319 => 244320)
--- trunk/Source/WebCore/ChangeLog 2019-04-16 01:43:30 UTC (rev 244319)
+++ trunk/Source/WebCore/ChangeLog 2019-04-16 01:55:50 UTC (rev 244320)
@@ -1,3 +1,16 @@
+2019-04-15 Eike Rathke <[email protected]>
+
+ Fix logic flow for error log
+ https://bugs.webkit.org/show_bug.cgi?id=196933
+
+ Reviewed by Alexey Proskuryakov.
+
+ Missing block braces logged an error always, not just
+ if (actionIfInvalid == Complain).
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::isSafeToLoadURL):
+
2019-04-15 Myles C. Maxfield <[email protected]>
[Cocoa] FontPlatformData objects aren't cached at all when using font-family:system-ui
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (244319 => 244320)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2019-04-16 01:43:30 UTC (rev 244319)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2019-04-16 01:55:50 UTC (rev 244320)
@@ -2098,9 +2098,10 @@
RefPtr<Frame> frame = document().frame();
if (!frame || !document().securityOrigin().canDisplay(url)) {
- if (actionIfInvalid == Complain)
+ if (actionIfInvalid == Complain) {
FrameLoader::reportLocalLoadFailed(frame.get(), url.stringCenterEllipsizedToLength());
ERROR_LOG(LOGIDENTIFIER, url , " was rejected by SecurityOrigin");
+ }
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
