Title: [244353] trunk
Revision
244353
Author
[email protected]
Date
2019-04-16 12:48:37 -0700 (Tue, 16 Apr 2019)

Log Message

Unprefix -webkit-sticky
https://bugs.webkit.org/show_bug.cgi?id=196962
<rdar://problem/40903458>

Reviewed by Simon Fraser.

Source/WebCore:

Updated existing tests.

This change doesn't modify functionality, only exposing a new unprefixed CSS value.

* css/CSSProperties.json:
* css/CSSValueKeywords.in:

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator PositionType const):

* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::convertPositionStyle):

Source/WebInspectorUI:

Replace all `-webkit-sticky` with `sticky`.

* UserInterface/Models/CSSKeywordCompletions.js:
* UserInterface/Views/AuditTestCaseContentView.css:
(.content-view-container > .content-view.audit-test-case > header):
* UserInterface/Views/AuditTestGroupContentView.css:
(.content-view.audit-test-group.contains-test-case > header):
* UserInterface/Views/ChangesDetailsSidebarPanel.css:
(.changes-panel .resource-section > .header):
* UserInterface/Views/DetailsSection.css:
(.details-section > .header):
* UserInterface/Views/NetworkDetailView.css:
(.network-detail .navigation-bar):
* UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings .navigation-bar):
* UserInterface/Views/Table.css:
(.table > .header):

LayoutTests:

* compositing/layer-creation/no-compositing-for-sticky.html:
* editing/pasteboard/copy-paste-converts-sticky.html:
* editing/pasteboard/copy-paste-converts-sticky-expected.txt:
* fast/block/positioning/fixed-container-with-sticky-parent.html:
* fast/block/sticky-position-containing-block-crash.html:
* fast/css/sticky/inflow-sticky.html:
* fast/css/sticky/inline-sticky-abspos-child.html:
* fast/css/sticky/inline-sticky.html:
* fast/css/sticky/multiple-layers-sticky-crash.html:
* fast/css/sticky/parsing-position-sticky-expected.txt:
* fast/css/sticky/remove-inline-sticky-crash.html:
* fast/css/sticky/remove-sticky-crash.html:
* fast/css/sticky/replaced-sticky.html:
* fast/css/sticky/resources/parsing-position-sticky.js:
* fast/css/sticky/sticky-as-positioning-container.html:
* fast/css/sticky/sticky-both-sides.html:
* fast/css/sticky/sticky-bottom-overflow-padding.html:
* fast/css/sticky/sticky-left-percentage.html:
* fast/css/sticky/sticky-left.html:
* fast/css/sticky/sticky-margins.html:
* fast/css/sticky/sticky-overflowing.html:
* fast/css/sticky/sticky-side-margins.html:
* fast/css/sticky/sticky-stacking-context.html:
* fast/css/sticky/sticky-stacking-context-expected.html:
* fast/css/sticky/sticky-table-row-top.html:
* fast/css/sticky/sticky-table-thead-top.html:
* fast/css/sticky/sticky-top-margins.html:
* fast/css/sticky/sticky-top-overflow-container-overflow.html:
* fast/css/sticky/sticky-top-overflow.html:
* fast/css/sticky/sticky-top-zoomed.html:
* fast/css/sticky/sticky-top-zoomed-expected.html:
* fast/css/sticky/sticky-top.html:
* fast/css/sticky/sticky-writing-mode-horizontal-bt.html:
* fast/css/sticky/sticky-writing-mode-vertical-lr.html:
* fast/css/sticky/sticky-writing-mode-vertical-rl.html:
* fast/multicol/newmulticol/table-section-crash.html:
* fast/scrolling/ios/reconcile-layer-position-recursive.html:
* fast/scrolling/rtl-scrollbars-sticky-document-2.html:
* fast/scrolling/rtl-scrollbars-sticky-document.html:
* fast/scrolling/rtl-scrollbars-sticky-iframe-2.html:
* fast/scrolling/rtl-scrollbars-sticky-iframe.html:
* fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html:
* fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html:
* fast/scrolling/sticky-to-fixed.html:
* legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html:
* scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:
* svg/text/select-text-inside-non-static-position.html:
* tiled-drawing/scrolling/sticky/negative-scroll-offset.html:
* tiled-drawing/scrolling/sticky/sticky-horizontal.html:
* tiled-drawing/scrolling/sticky/sticky-layers.html:
* tiled-drawing/scrolling/sticky/sticky-vertical.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (244352 => 244353)


--- trunk/LayoutTests/ChangeLog	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/ChangeLog	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1,3 +1,63 @@
+2019-04-16  Devin Rousso  <[email protected]>
+
+        Unprefix -webkit-sticky
+        https://bugs.webkit.org/show_bug.cgi?id=196962
+        <rdar://problem/40903458>
+
+        Reviewed by Simon Fraser.
+
+        * compositing/layer-creation/no-compositing-for-sticky.html:
+        * editing/pasteboard/copy-paste-converts-sticky.html:
+        * editing/pasteboard/copy-paste-converts-sticky-expected.txt:
+        * fast/block/positioning/fixed-container-with-sticky-parent.html:
+        * fast/block/sticky-position-containing-block-crash.html:
+        * fast/css/sticky/inflow-sticky.html:
+        * fast/css/sticky/inline-sticky-abspos-child.html:
+        * fast/css/sticky/inline-sticky.html:
+        * fast/css/sticky/multiple-layers-sticky-crash.html:
+        * fast/css/sticky/parsing-position-sticky-expected.txt:
+        * fast/css/sticky/remove-inline-sticky-crash.html:
+        * fast/css/sticky/remove-sticky-crash.html:
+        * fast/css/sticky/replaced-sticky.html:
+        * fast/css/sticky/resources/parsing-position-sticky.js:
+        * fast/css/sticky/sticky-as-positioning-container.html:
+        * fast/css/sticky/sticky-both-sides.html:
+        * fast/css/sticky/sticky-bottom-overflow-padding.html:
+        * fast/css/sticky/sticky-left-percentage.html:
+        * fast/css/sticky/sticky-left.html:
+        * fast/css/sticky/sticky-margins.html:
+        * fast/css/sticky/sticky-overflowing.html:
+        * fast/css/sticky/sticky-side-margins.html:
+        * fast/css/sticky/sticky-stacking-context.html:
+        * fast/css/sticky/sticky-stacking-context-expected.html:
+        * fast/css/sticky/sticky-table-row-top.html:
+        * fast/css/sticky/sticky-table-thead-top.html:
+        * fast/css/sticky/sticky-top-margins.html:
+        * fast/css/sticky/sticky-top-overflow-container-overflow.html:
+        * fast/css/sticky/sticky-top-overflow.html:
+        * fast/css/sticky/sticky-top-zoomed.html:
+        * fast/css/sticky/sticky-top-zoomed-expected.html:
+        * fast/css/sticky/sticky-top.html:
+        * fast/css/sticky/sticky-writing-mode-horizontal-bt.html:
+        * fast/css/sticky/sticky-writing-mode-vertical-lr.html:
+        * fast/css/sticky/sticky-writing-mode-vertical-rl.html:
+        * fast/multicol/newmulticol/table-section-crash.html:
+        * fast/scrolling/ios/reconcile-layer-position-recursive.html:
+        * fast/scrolling/rtl-scrollbars-sticky-document-2.html:
+        * fast/scrolling/rtl-scrollbars-sticky-document.html:
+        * fast/scrolling/rtl-scrollbars-sticky-iframe-2.html:
+        * fast/scrolling/rtl-scrollbars-sticky-iframe.html:
+        * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html:
+        * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html:
+        * fast/scrolling/sticky-to-fixed.html:
+        * legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html:
+        * scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:
+        * svg/text/select-text-inside-non-static-position.html:
+        * tiled-drawing/scrolling/sticky/negative-scroll-offset.html:
+        * tiled-drawing/scrolling/sticky/sticky-horizontal.html:
+        * tiled-drawing/scrolling/sticky/sticky-layers.html:
+        * tiled-drawing/scrolling/sticky/sticky-vertical.html:
+
 2019-04-16  John Wilander  <[email protected]>
 
         Increase timeout threshold in http/tests/adClickAttribution/send-attribution-conversion-request.html to address flakiness

Modified: trunk/LayoutTests/compositing/layer-creation/no-compositing-for-sticky.html (244352 => 244353)


--- trunk/LayoutTests/compositing/layer-creation/no-compositing-for-sticky.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/compositing/layer-creation/no-compositing-for-sticky.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -25,7 +25,7 @@
     }
     
     .sticky {
-      position: -webkit-sticky;
+      position: sticky;
       display: inline-block;
       background: silver;
       margin: 4px;

Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt (244352 => 244353)


--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky-expected.txt	2019-04-16 19:48:37 UTC (rev 244353)
@@ -21,7 +21,7 @@
 |     "
 abc"
 |     <div>
-|       style="position: -webkit-sticky; left: 0px; top: 0px;"
+|       style="position: sticky; left: 0px; top: 0px;"
 |       "def"
 |     "ghi
 "

Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html (244352 => 244353)


--- trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-converts-sticky.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -4,7 +4,7 @@
 <script type="text/_javascript_" src=""
 </head>
 <body>
-abc<div style="position: -webkit-sticky; left: 0px; top: 0px;">def</div>ghi
+abc<div style="position: sticky; left: 0px; top: 0px;">def</div>ghi
 <br/>
 
 <script>

Modified: trunk/LayoutTests/fast/block/positioning/fixed-container-with-sticky-parent.html (244352 => 244353)


--- trunk/LayoutTests/fast/block/positioning/fixed-container-with-sticky-parent.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/block/positioning/fixed-container-with-sticky-parent.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -8,10 +8,10 @@
 </script>
 </head>
 <body>
-<div style="position: -webkit-sticky; left: 50px; width: 20px; height: 20px; border: 1px solid green;">
+<div style="position: sticky; left: 50px; width: 20px; height: 20px; border: 1px solid green;">
   <div class=fixed style="width: 20px; height: 20px; background-color: green;"></div>
 </div>
-<div style="position: -webkit-sticky; left: 50px; width: 20px; height: 20px; margin: 5px; border: 1px solid green;">
+<div style="position: sticky; left: 50px; width: 20px; height: 20px; margin: 5px; border: 1px solid green;">
   <div class=fixed style="width: 20px; height: 20px; background-color: green;"></div>
 </div>
 

Modified: trunk/LayoutTests/fast/block/sticky-position-containing-block-crash.html (244352 => 244353)


--- trunk/LayoutTests/fast/block/sticky-position-containing-block-crash.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/block/sticky-position-containing-block-crash.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -7,7 +7,7 @@
     <div>
       <i>
         <i>
-          <i style="position: -webkit-sticky; display: table-footer-group;">
+          <i style="position: sticky; display: table-footer-group;">
             <span></span>
           </i>
         </i>

Modified: trunk/LayoutTests/fast/css/sticky/inflow-sticky.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/inflow-sticky.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/inflow-sticky.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -37,7 +37,7 @@
     }
     .sticky {
         background-color: green;
-        position: -webkit-sticky;
+        position: sticky;
         top: 300px;
     }
 </style>

Modified: trunk/LayoutTests/fast/css/sticky/inline-sticky-abspos-child.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/inline-sticky-abspos-child.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/inline-sticky-abspos-child.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -34,7 +34,7 @@
         width: 200px;
         height: 200px;
         color: blue;
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
     }
     

Modified: trunk/LayoutTests/fast/css/sticky/inline-sticky.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/inline-sticky.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/inline-sticky.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -34,7 +34,7 @@
         width: 200px;
         height: 200px;
         color: blue;
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
     }
     

Modified: trunk/LayoutTests/fast/css/sticky/multiple-layers-sticky-crash.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/multiple-layers-sticky-crash.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/multiple-layers-sticky-crash.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -12,7 +12,7 @@
     }
 
     div {
-      position: -webkit-sticky;
+      position: sticky;
     }
   </style>
 </head>

Modified: trunk/LayoutTests/fast/css/sticky/parsing-position-sticky-expected.txt (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/parsing-position-sticky-expected.txt	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/parsing-position-sticky-expected.txt	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1,10 +1,10 @@
-This tests checks that the -webkit-sticky value for position parses correctly.
+This tests checks that the sticky value for position parses correctly.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
 PASS test("position: -webkit-sticky;") is "-webkit-sticky"
-PASS test("position: sticky;") is ""
+PASS test("position: sticky;") is "sticky"
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/css/sticky/remove-inline-sticky-crash.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/remove-inline-sticky-crash.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/remove-inline-sticky-crash.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -14,7 +14,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/remove-sticky-crash.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/remove-sticky-crash.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/remove-sticky-crash.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -14,7 +14,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/replaced-sticky.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/replaced-sticky.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/replaced-sticky.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -29,7 +29,7 @@
     
     .sticky {
         background-color: silver;
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
     }
     

Modified: trunk/LayoutTests/fast/css/sticky/resources/parsing-position-sticky.js (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/resources/parsing-position-sticky.js	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/resources/parsing-position-sticky.js	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1,4 +1,4 @@
-description("This tests checks that the -webkit-sticky value for position parses correctly.");
+description("This tests checks that the sticky value for position parses correctly.");
 
 function test(value)
 {
@@ -12,4 +12,4 @@
 }
 
 shouldBe('test("position: -webkit-sticky;")', '"-webkit-sticky"');
-shouldBeEqualToString('test("position: sticky;")', '');
+shouldBe('test("position: sticky;")', '"sticky"');

Modified: trunk/LayoutTests/fast/css/sticky/sticky-as-positioning-container.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-as-positioning-container.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-as-positioning-container.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -28,7 +28,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: silver;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-both-sides.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-both-sides.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-both-sides.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -35,7 +35,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         left: 50px;
         right: 50px;
         background-color: green;

Modified: trunk/LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-bottom-overflow-padding.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -35,7 +35,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         bottom: 0px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-left-percentage.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-left-percentage.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-left-percentage.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -27,7 +27,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         /* DRT window is 800px wide */
         left: 12.5%;
         background-color: green;

Modified: trunk/LayoutTests/fast/css/sticky/sticky-left.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-left.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-left.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -27,7 +27,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         left: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-margins.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-margins.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-margins.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -29,7 +29,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 10px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-overflowing.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-overflowing.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-overflowing.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -46,7 +46,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 200px;
         right: 200px;
         background-color: green;

Modified: trunk/LayoutTests/fast/css/sticky/sticky-side-margins.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-side-margins.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-side-margins.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -27,7 +27,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         left: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-stacking-context-expected.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-stacking-context-expected.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-stacking-context-expected.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -19,7 +19,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
     }
     
     .child {

Modified: trunk/LayoutTests/fast/css/sticky/sticky-stacking-context.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-stacking-context.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-stacking-context.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -18,7 +18,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
     }
     
     .intermediate {

Modified: trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -35,7 +35,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-table-thead-top.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-table-thead-top.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-table-thead-top.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -35,7 +35,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-top-margins.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-top-margins.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-top-margins.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -29,7 +29,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 10px;
         margin: 20px;
         background-color: green;

Modified: trunk/LayoutTests/fast/css/sticky/sticky-top-overflow-container-overflow.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-top-overflow-container-overflow.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-top-overflow-container-overflow.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -34,7 +34,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-top-overflow.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-top-overflow.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-top-overflow.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -34,7 +34,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed-expected.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed-expected.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed-expected.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -32,7 +32,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 75px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-top-zoomed.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -32,7 +32,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 75px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-top.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-top.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-top.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -28,7 +28,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         background-color: green;
     }

Modified: trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-horizontal-bt.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-horizontal-bt.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-horizontal-bt.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -30,7 +30,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         top: 100px;
         bottom: 100px;
         background-color: green;

Modified: trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-lr.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -29,7 +29,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         background-color: green;
         width: 100px;
         height: 100px;

Modified: trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl.html (244352 => 244353)


--- trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/css/sticky/sticky-writing-mode-vertical-rl.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -29,7 +29,7 @@
     }
 
     .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         background-color: green;
         width: 100px;
         height: 100px;

Modified: trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html (244352 => 244353)


--- trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/multicol/newmulticol/table-section-crash.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -18,7 +18,7 @@
     head.appendChild(style);
     style = document.createElement("style");
     style.innerHTML = "* { \n\
-        position: -webkit-sticky;\n\
+        position: sticky;\n\
         -webkit-animation-direction: alternate-reverse;";
 
     head.appendChild(style);

Modified: trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -19,7 +19,6 @@
          background: yellow;
       }
       .sticky {
-         position: -webkit-sticky;
          position: sticky;
          height: 100px;
          width: 100px;

Modified: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -11,7 +11,7 @@
 <body style="margin: 0px;">
 This test makes sure that position-sticky obeys RTL scrollbars when positioning.
 <div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
-    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
 </div>
 <script>
 window.scroll(850, 0);

Modified: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -11,7 +11,7 @@
 <body style="margin: 0px;">
 This test makes sure that position-sticky obeys RTL scrollbars when positioning.
 <div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
-    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
 </div>
 </body>
 </html>

Modified: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -15,7 +15,7 @@
 </head>
 <body>
 <div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
-    <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
+    <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
 </div>
 <script>
 window.scroll(850, 0);

Modified: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -15,7 +15,7 @@
 </head>
 <body>
 <div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
-    <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
+    <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
 </div>
 </body>
 </html">

Modified: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -12,7 +12,7 @@
 This test makes sure that position-sticky obeys RTL scrollbars when positioning.
 <div id="scrolling" style="position: relative; width: 600px; height: 500px; overflow: scroll;">
 <div style="position: absolute; top: 0px; left: 0px; width: 2000px;">
-    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
 </div>
 </div>
 <script>

Modified: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -12,7 +12,7 @@
 This test makes sure that position-sticky obeys RTL scrollbars when positioning.
 <div style="position: relative; width: 600px; height: 500px; overflow: scroll;">
 <div style="position: absolute; top: 0px; left: 0px; width: 2000px;">
-    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+    <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
 </div>
 </div>
 </body>

Modified: trunk/LayoutTests/fast/scrolling/sticky-to-fixed.html (244352 => 244353)


--- trunk/LayoutTests/fast/scrolling/sticky-to-fixed.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/fast/scrolling/sticky-to-fixed.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -6,7 +6,7 @@
     height: 2000px;
 }
 .masthead {
-    position: -webkit-sticky;
+    position: sticky;
     width: 200px;
     height: 100px;
     background-color: rgba(0, 0, 0, 0.2);

Modified: trunk/LayoutTests/legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html (244352 => 244353)


--- trunk/LayoutTests/legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -18,7 +18,7 @@
     head.appendChild(style);
     style = document.createElement("style");
     style.innerHTML = "* { \n\
-        position: -webkit-sticky;\n\
+        position: sticky;\n\
         -webkit-animation-direction: alternate-reverse;";
 
     head.appendChild(style);

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html (244352 => 244353)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -23,7 +23,7 @@
             background-color: silver;
         }
         .sticky {
-            position: -webkit-sticky;
+            position: sticky;
             top: 10px;
             bottom: 10px;
         }

Modified: trunk/LayoutTests/svg/text/select-text-inside-non-static-position.html (244352 => 244353)


--- trunk/LayoutTests/svg/text/select-text-inside-non-static-position.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/svg/text/select-text-inside-non-static-position.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -3,7 +3,7 @@
 <head>
 <style>
 * {
-    position: -webkit-sticky;
+    position: sticky;
     -webkit-transform: scaleX(2);
 }
 </style>

Modified: trunk/LayoutTests/tiled-drawing/scrolling/sticky/negative-scroll-offset.html (244352 => 244353)


--- trunk/LayoutTests/tiled-drawing/scrolling/sticky/negative-scroll-offset.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/tiled-drawing/scrolling/sticky/negative-scroll-offset.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -6,7 +6,7 @@
       }
 
       .sticky {
-        position: -webkit-sticky;
+        position: sticky;
         width: 100%;
         height: 50px;
         left: 0;

Modified: trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-horizontal.html (244352 => 244353)


--- trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-horizontal.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-horizontal.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -24,7 +24,7 @@
     }
     
     .sticky {
-      position: -webkit-sticky;
+      position: sticky;
       display: inline-block;
       background: silver;
       margin: 4px;

Modified: trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-layers.html (244352 => 244353)


--- trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-layers.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-layers.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -24,7 +24,7 @@
     }
     
     .sticky {
-      position: -webkit-sticky;
+      position: sticky;
       display: inline-block;
       background: silver;
       margin: 4px;

Modified: trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-vertical.html (244352 => 244353)


--- trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-vertical.html	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/LayoutTests/tiled-drawing/scrolling/sticky/sticky-vertical.html	2019-04-16 19:48:37 UTC (rev 244353)
@@ -19,7 +19,7 @@
     
     .sticky {
       float: left;
-      position: -webkit-sticky;
+      position: sticky;
       background: silver;
       margin: 5px;
       height: 300px;

Modified: trunk/Source/WebCore/ChangeLog (244352 => 244353)


--- trunk/Source/WebCore/ChangeLog	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebCore/ChangeLog	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1,3 +1,28 @@
+2019-04-16  Devin Rousso  <[email protected]>
+
+        Unprefix -webkit-sticky
+        https://bugs.webkit.org/show_bug.cgi?id=196962
+        <rdar://problem/40903458>
+
+        Reviewed by Simon Fraser.
+
+        Updated existing tests.
+
+        This change doesn't modify functionality, only exposing a new unprefixed CSS value.
+
+        * css/CSSProperties.json:
+        * css/CSSValueKeywords.in:
+
+        * css/CSSPrimitiveValueMappings.h:
+        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+        (WebCore::CSSPrimitiveValue::operator PositionType const):
+
+        * css/parser/CSSParserFastPaths.cpp:
+        (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+
+        * editing/EditingStyle.cpp:
+        (WebCore::EditingStyle::convertPositionStyle):
+
 2019-04-16  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r244321.

Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (244352 => 244353)


--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2019-04-16 19:48:37 UTC (rev 244353)
@@ -2335,7 +2335,7 @@
         m_value.valueID = CSSValueFixed;
         break;
     case PositionType::Sticky:
-        m_value.valueID = CSSValueWebkitSticky;
+        m_value.valueID = CSSValueSticky;
         break;
     }
 }
@@ -2353,6 +2353,7 @@
         return PositionType::Absolute;
     case CSSValueFixed:
         return PositionType::Fixed;
+    case CSSValueSticky:
     case CSSValueWebkitSticky:
         return PositionType::Sticky;
     default:

Modified: trunk/Source/WebCore/css/CSSProperties.json (244352 => 244353)


--- trunk/Source/WebCore/css/CSSProperties.json	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebCore/css/CSSProperties.json	2019-04-16 19:48:37 UTC (rev 244353)
@@ -3501,9 +3501,12 @@
                 "absolute",
                 "fixed",
                 {
+                    "value": "sticky",
+                    "url": "https://www.w3.org/TR/css-position-3/#valdef-position-sticky"
+                },
+                {
                     "value": "-webkit-sticky",
-                    "status": "experimental",
-                    "url": "https://www.w3.org/TR/css-position-3/#valdef-position-sticky"
+                    "status": "deprecated"
                 }
             ],
             "specification": {

Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (244352 => 244353)


--- trunk/Source/WebCore/css/CSSValueKeywords.in	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1153,6 +1153,7 @@
 alphabetic
 
 // position
+sticky
 -webkit-sticky
 
 // (pointer:) media feature

Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (244352 => 244353)


--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2019-04-16 19:48:37 UTC (rev 244353)
@@ -627,7 +627,11 @@
         // painted | fill | stroke | auto | all | bounding-box
         return valueID == CSSValueVisible || valueID == CSSValueNone || valueID == CSSValueAll || valueID == CSSValueAuto || (valueID >= CSSValueVisiblePainted && valueID <= CSSValueStroke);
     case CSSPropertyPosition: // static | relative | absolute | fixed | sticky
-        return valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed || valueID == CSSValueWebkitSticky;
+        return valueID == CSSValueStatic
+            || valueID == CSSValueRelative
+            || valueID == CSSValueAbsolute
+            || valueID == CSSValueFixed
+            || valueID == CSSValueSticky || valueID == CSSValueWebkitSticky;
     case CSSPropertyResize: // none | both | horizontal | vertical | auto
         return valueID == CSSValueNone || valueID == CSSValueBoth || valueID == CSSValueHorizontal || valueID == CSSValueVertical || valueID == CSSValueAuto;
     // FIXME-NEWPARSER: Investigate this property.

Modified: trunk/Source/WebCore/editing/EditingStyle.cpp (244352 => 244353)


--- trunk/Source/WebCore/editing/EditingStyle.cpp	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebCore/editing/EditingStyle.cpp	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1389,7 +1389,7 @@
         return false;
 
     auto& cssValuePool = CSSValuePool::singleton();
-    RefPtr<CSSPrimitiveValue> sticky = cssValuePool.createIdentifierValue(CSSValueWebkitSticky);
+    RefPtr<CSSPrimitiveValue> sticky = cssValuePool.createIdentifierValue(CSSValueSticky);
     if (m_mutableStyle->propertyMatches(CSSPropertyPosition, sticky.get())) {
         m_mutableStyle->setProperty(CSSPropertyPosition, cssValuePool.createIdentifierValue(CSSValueStatic), m_mutableStyle->propertyIsImportant(CSSPropertyPosition));
         return false;

Modified: trunk/Source/WebInspectorUI/ChangeLog (244352 => 244353)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1,5 +1,31 @@
 2019-04-16  Devin Rousso  <[email protected]>
 
+        Unprefix -webkit-sticky
+        https://bugs.webkit.org/show_bug.cgi?id=196962
+        <rdar://problem/40903458>
+
+        Reviewed by Simon Fraser.
+
+        Replace all `-webkit-sticky` with `sticky`.
+
+        * UserInterface/Models/CSSKeywordCompletions.js:
+        * UserInterface/Views/AuditTestCaseContentView.css:
+        (.content-view-container > .content-view.audit-test-case > header):
+        * UserInterface/Views/AuditTestGroupContentView.css:
+        (.content-view.audit-test-group.contains-test-case > header):
+        * UserInterface/Views/ChangesDetailsSidebarPanel.css:
+        (.changes-panel .resource-section > .header):
+        * UserInterface/Views/DetailsSection.css:
+        (.details-section > .header):
+        * UserInterface/Views/NetworkDetailView.css:
+        (.network-detail .navigation-bar):
+        * UserInterface/Views/SettingsTabContentView.css:
+        (.content-view.settings .navigation-bar):
+        * UserInterface/Views/Table.css:
+        (.table > .header):
+
+2019-04-16  Devin Rousso  <[email protected]>
+
         Web Inspector: remove unused WI.DOMTreeDataGrid
         https://bugs.webkit.org/show_bug.cgi?id=196958
         <rdar://problem/49931383>

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js	2019-04-16 19:48:37 UTC (rev 244353)
@@ -1132,7 +1132,7 @@
         "none", "all", "auto", "visible", "visiblePainted", "visibleFill", "visibleStroke", "painted", "fill", "stroke",
     ],
     "position": [
-        "absolute", "fixed", "relative", "static", "-webkit-sticky",
+        "absolute", "fixed", "relative", "static", "sticky", "-webkit-sticky",
     ],
     "resize": [
         "none", "auto", "both", "horizontal", "vertical",

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.css (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.css	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.css	2019-04-16 19:48:37 UTC (rev 244353)
@@ -24,7 +24,7 @@
  */
 
 .content-view-container > .content-view.audit-test-case > header {
-    position: -webkit-sticky;
+    position: sticky;
     top: -1px;
     z-index: var(--z-index-header);
     margin-top: -1px;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css	2019-04-16 19:48:37 UTC (rev 244353)
@@ -43,7 +43,7 @@
 }
 
 .content-view.audit-test-group.contains-test-case > header {
-    position: -webkit-sticky;
+    position: sticky;
     top: -1px;
     z-index: var(--z-index-header);
     background-color: var(--audit-test-header-background-color);

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css	2019-04-16 19:48:37 UTC (rev 244353)
@@ -51,7 +51,7 @@
 }
 
 .changes-panel .resource-section > .header {
-    position: -webkit-sticky;
+    position: sticky;
     top: 0;
     z-index: var(--z-index-header);
     padding: 4px 8px;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css	2019-04-16 19:48:37 UTC (rev 244353)
@@ -43,7 +43,7 @@
 }
 
 .details-section > .header {
-    position: -webkit-sticky;
+    position: sticky;
     top: -1px;
     height: 23px;
     padding: 4px 0;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.css (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.css	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.css	2019-04-16 19:48:37 UTC (rev 244353)
@@ -35,7 +35,7 @@
 }
 
 .network-detail .navigation-bar {
-    position: -webkit-sticky;
+    position: sticky;
     top: 0;
     z-index: 1;
 }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css	2019-04-16 19:48:37 UTC (rev 244353)
@@ -30,7 +30,7 @@
 }
 
 .content-view.settings .navigation-bar {
-    position: -webkit-sticky;
+    position: sticky;
     top: 0;
     z-index: 1;
     background-color: white;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.css (244352 => 244353)


--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.css	2019-04-16 19:46:27 UTC (rev 244352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.css	2019-04-16 19:48:37 UTC (rev 244353)
@@ -35,7 +35,7 @@
 }
 
 .table > .header {
-    position: -webkit-sticky;
+    position: sticky;
     top: 0;
     height: var(--navigation-bar-height);
     line-height: calc(var(--navigation-bar-height) - 1px);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to